Skip to content

[17.0][ADD] product_margin_report_landed_costs #247

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
edescalona wants to merge 1 commit into
base: 17.0
Choose a base branch
from
Open

[17.0][ADD] product_margin_report_landed_costs #247

edescalona wants to merge 1 commit into from

Conversation

@edescalona
Copy link

@edescalona edescalona commented Aug 5, 2025

@BinhexTeam

Add the landed costs associated with the product to the Product Margins report.

@edescalona edescalona force-pushed the 17.0-add-product_margin_report_landed_costs branch 4 times, most recently from fd3dd39 to 0c197cc Compare August 5, 2025 18:50
@edescalona edescalona marked this pull request as ready for review August 5, 2025 18:59
rrebollo
rrebollo approved these changes Sep 9, 2025
View reviewed changes
Copy link

@rrebollo rrebollo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pure Code Review. LGTM!!! I do think functional review is critical on this kind of addons. Great contribution.

@rrebollo
Copy link

rrebollo commented Sep 9, 2025

I don't have extensive knowledge of stock valuation methodologies, but I am aware of the key differences between Anglo-Saxon and Continental accounting principles. Perhaps you could mention any prerequisites regarding those accounting standards in addon's documentation.

@edescalona
[ADD] product_margin_report_landed_costs: Add the landed costs associ…
6ed45cf 
…ated with the product to the Product Margins report.
@edescalona edescalona force-pushed the 17.0-add-product_margin_report_landed_costs branch from 0c197cc to 6ed45cf Compare September 11, 2025 19:14
@edescalona
Copy link
Author

edescalona commented Sep 11, 2025

ping @rrebollo

@rrebollo
Copy link

rrebollo commented Sep 12, 2025

Nice job @edescalona

@edescalona
Copy link
Author

edescalona commented Sep 24, 2025

ping @Christian-RB

@github-actions
Copy link

github-actions bot commented Jan 25, 2026

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days.
If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.

@github-actions github-actions bot added the stale PR/Issue without recent activity, it'll be soon closed automatically. label Jan 25, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@rrebollo rrebollo rrebollo approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

stale PR/Issue without recent activity, it'll be soon closed automatically.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@edescalona @rrebollo