[10.0][IMP] document_page: Change Requests and workflow improvements on documents (#155) #159
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Apr 13, 2018
Member
|
The module is already migrated, so this is an improvement. |
pedrobaeza
changed the title
Contributor
Author
|
Well, yeah, it's the migration of an improvement pushed to |
Member
|
Yeah, it's better to indicate correctly when seeing the commit history for this module for not seeing 2 times "migration to 10.0" |
Contributor
Author
|
@max3903 these are ready. Runbot and travis are failing because they need each other. |
Contributor
Author
|
`document_page` does not depend on `document_page_approval`, but the old
`document_page_approval` can't depend on the new `document_page`, so it's
red.
El vie., 13 de abr. de 2018 a la(s) 18:04, Maxime Chambreuil <
[email protected]> escribió:
@ivantodorovich <https://github.com/ivantodorovich> document_page does
not depend on document_page_approval so this pull request should be green.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#159 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AB01SfxMqv-kRNmgzLAylB1_xo3BDOZVks5toRLpgaJpZM4TTkPo>
.
--
Iván Todorovich
|
Member
|
@ivantodorovich Yep, I understood this after writing the message. That's why I deleted it. Thanks! |
Contributor
Author
|
|
max3903
approved these changes
Apr 16, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mig #155 to
10.0(1/2)Depends on #160