Skip to content

[IMP] Set a default icon per module #27

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
pedrobaeza merged 2 commits into from
Oct 11, 2018
Merged

[IMP] Set a default icon per module #27

pedrobaeza merged 2 commits into from
Oct 11, 2018

Conversation

@StephanRozendaal
Copy link
Contributor

@StephanRozendaal StephanRozendaal commented Oct 3, 2018

Change includes:

  • Set a default icon per Odoo module

@StephanRozendaal
[IMP] Set a default icon per module
4c0124b 
Set a default icon per module, when no icon is defined in that
module. The default icon is the 'OCA cube', the icon is located
in the module itself (in /data/oca.png).
elicoidal
elicoidal approved these changes Oct 3, 2018
View reviewed changes
Copy link

@elicoidal elicoidal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.
Version number

@elicoidal elicoidal added this to the 11.0 milestone Oct 3, 2018
@StephanRozendaal
[IMP] Update version to 11.0.1.2.0
f8f60ea 
Update version to 11.0.1.2.0
legalsylvain
legalsylvain requested changes Oct 6, 2018
View reviewed changes
Copy link
Contributor

@legalsylvain legalsylvain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, As the module github_connector_odoo can fetch many repositories, I think this proposal is not very extendable because we can fetch many organization with that module. (Specially if we are integrators, we can fetch our repositories, and the OCA repository).

I'd prefer to add on the organization, a new field name default_odoo_image, that would be used if no image are found. What do you think ?
if yes, you could move the current oca.png image in the demo data.

regards

@StephanRozendaal
Copy link
Contributor Author

StephanRozendaal commented Oct 6, 2018

@legalsylvain : Thanks for you comments.

I agree with your proposal, It's better if we make it configurable.
I can pick this up in the coming days.
Regards,

@elicoidal
Copy link

elicoidal commented Oct 6, 2018

@legalsylvain Agree!

@bizzappdev
Copy link
Contributor

bizzappdev commented Oct 8, 2018

@StephanRozendaal @legalsylvain we can also use the Image of the Organization.
selection_213

@bizzappdev bizzappdev mentioned this pull request Oct 8, 2018
Merged
@pedrobaeza pedrobaeza merged commit f36191b into OCA:11.0 Oct 11, 2018
@pedrobaeza
Copy link
Member

pedrobaeza commented Oct 11, 2018

Merged for not getting the problem. @sbidoul please deploy also this one.

@sbidoul
Copy link
Member

sbidoul commented Oct 11, 2018

It's deployed.

cubells pushed a commit to Tecnativa/interface-github that referenced this pull request Apr 5, 2019
@StephanRozendaal @cubells
[IMP] Set a default icon per module (OCA#27)
7878be0 
Set a default icon per module, when no icon is defined in that
module. The default icon is the 'OCA cube', the icon is located
in the module itself (in /data/oca.png).
Tardo pushed a commit to Tecnativa/interface-github that referenced this pull request Apr 14, 2020
@StephanRozendaal @Tardo
[IMP] Set a default icon per module (OCA#27)
a3cbf89 
Set a default icon per module, when no icon is defined in that
module. The default icon is the 'OCA cube', the icon is located
in the module itself (in /data/oca.png).
Tardo pushed a commit to Tecnativa/interface-github that referenced this pull request Jun 17, 2020
@StephanRozendaal @Tardo
[IMP] Set a default icon per module (OCA#27)
53278fe 
Set a default icon per module, when no icon is defined in that
module. The default icon is the 'OCA cube', the icon is located
in the module itself (in /data/oca.png).
pedrobaeza pushed a commit to Tecnativa/interface-github that referenced this pull request Jun 18, 2020
@StephanRozendaal @pedrobaeza
[IMP] Set a default icon per module (OCA#27)
f98e76d 
Set a default icon per module, when no icon is defined in that
module. The default icon is the 'OCA cube', the icon is located
in the module itself (in /data/oca.png).
OpenCode pushed a commit to OpenCode/interface-github that referenced this pull request Jul 15, 2021
@StephanRozendaal @OpenCode
[IMP] Set a default icon per module (OCA#27)
a903192 
Set a default icon per module, when no icon is defined in that
module. The default icon is the 'OCA cube', the icon is located
in the module itself (in /data/oca.png).
ernestotejeda pushed a commit to Tecnativa/interface-github that referenced this pull request Jul 30, 2021
@StephanRozendaal
[IMP] Set a default icon per module (OCA#27)
c7231b2 
Set a default icon per module, when no icon is defined in that
module. The default icon is the 'OCA cube', the icon is located
in the module itself (in /data/oca.png).
OpenCode pushed a commit to OpenCode/interface-github that referenced this pull request Jun 23, 2022
@StephanRozendaal @OpenCode
[IMP] Set a default icon per module (OCA#27)
bc463a7 
Set a default icon per module, when no icon is defined in that
module. The default icon is the 'OCA cube', the icon is located
in the module itself (in /data/oca.png).
victoralmau pushed a commit to Tecnativa/interface-github that referenced this pull request Nov 17, 2022
@StephanRozendaal @victoralmau
[IMP] Set a default icon per module (OCA#27)
280db5e 
Set a default icon per module, when no icon is defined in that
module. The default icon is the 'OCA cube', the icon is located
in the module itself (in /data/oca.png).
carolinafernandez-tecnativa pushed a commit to Tecnativa/interface-github that referenced this pull request Jan 9, 2024
@StephanRozendaal @carolinafernandez-tecnativa
[IMP] Set a default icon per module (OCA#27)
cc3a9ba 
Set a default icon per module, when no icon is defined in that
module. The default icon is the 'OCA cube', the icon is located
in the module itself (in /data/oca.png).
carolinafernandez-tecnativa pushed a commit to Tecnativa/interface-github that referenced this pull request Mar 7, 2024
@StephanRozendaal @carolinafernandez-tecnativa
[IMP] Set a default icon per module (OCA#27)
7de7185 
Set a default icon per module, when no icon is defined in that
module. The default icon is the 'OCA cube', the icon is located
in the module itself (in /data/oca.png).
victoralmau pushed a commit to Tecnativa/interface-github that referenced this pull request Nov 8, 2024
@StephanRozendaal @victoralmau
[IMP] Set a default icon per module (OCA#27)
800bc9b 
Set a default icon per module, when no icon is defined in that
module. The default icon is the 'OCA cube', the icon is located
in the module itself (in /data/oca.png).
victoralmau pushed a commit to Tecnativa/interface-github that referenced this pull request Nov 11, 2024
@StephanRozendaal @victoralmau
[IMP] Set a default icon per module (OCA#27)
276b23f 
Set a default icon per module, when no icon is defined in that
module. The default icon is the 'OCA cube', the icon is located
in the module itself (in /data/oca.png).
carlos-lopez-tecnativa pushed a commit to Tecnativa/interface-github that referenced this pull request May 20, 2025
@StephanRozendaal @carlos-lopez-tecnativa
[IMP] Set a default icon per module (OCA#27)
9ff7420 
Set a default icon per module, when no icon is defined in that
module. The default icon is the 'OCA cube', the icon is located
in the module itself (in /data/oca.png).
carlos-lopez-tecnativa pushed a commit to Tecnativa/interface-github that referenced this pull request May 21, 2025
@StephanRozendaal @carlos-lopez-tecnativa
[IMP] Set a default icon per module (OCA#27)
747b511 
Set a default icon per module, when no icon is defined in that
module. The default icon is the 'OCA cube', the icon is located
in the module itself (in /data/oca.png).
juppe pushed a commit to ahkio/interface-github that referenced this pull request Dec 15, 2025
@StephanRozendaal @juppe
[IMP] Set a default icon per module (OCA#27)
cfff97c 
Set a default icon per module, when no icon is defined in that
module. The default icon is the 'OCA cube', the icon is located
in the module itself (in /data/oca.png).
juppe pushed a commit to ahkio/interface-github that referenced this pull request Dec 15, 2025
@StephanRozendaal @juppe
[IMP] Set a default icon per module (OCA#27)
c8e0cc6 
Set a default icon per module, when no icon is defined in that
module. The default icon is the 'OCA cube', the icon is located
in the module itself (in /data/oca.png).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@legalsylvain legalsylvain legalsylvain requested changes

+1 more reviewer

@elicoidal elicoidal elicoidal approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

needs review

Projects

None yet

Milestone

11.0

Development

Successfully merging this pull request may close these issues.

6 participants

@StephanRozendaal @elicoidal @bizzappdev @pedrobaeza @sbidoul @legalsylvain