Skip to content

[WIP][11.0] icon from manifest #23

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
pedrobaeza merged 3 commits into from
Oct 2, 2018
Merged

[WIP][11.0] icon from manifest #23

pedrobaeza merged 3 commits into from
Oct 2, 2018

Conversation

@StephanRozendaal
Copy link
Contributor

@StephanRozendaal StephanRozendaal commented Oct 1, 2018

Add the following changes:

  • Get an icon for the module from the manifest file
  • rename reaonly to readonly in a field

I think this change needs a unit-test to confirm that this works OK.

@StephanRozendaal
[REF]Fix field property
18a13f0 
The property is 'readony'.
@StephanRozendaal
[IMP]Get module icon from multiple sources
fc7c263 
Get the module icon from the following sources (in order):
 1. From the first entry of the images tag from the manifest
 2. From the static directory
@elicoidal elicoidal added this to the 11.0 milestone Oct 1, 2018
elicoidal
elicoidal approved these changes Oct 1, 2018
View reviewed changes
Copy link

@elicoidal elicoidal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.
Version number

github_connector_odoo/models/odoo_module_version.py
compute='_compute_odoo_type')

image = fields.Binary(string='Icon Image', reaonly=True)
image = fields.Binary(string='Icon Image', readonly=True)
Copy link

@elicoidal elicoidal Oct 1, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@bizzappdev
Copy link
Contributor

bizzappdev commented Oct 1, 2018

LGTM

@pedrobaeza pedrobaeza merged commit 1f9dd68 into OCA:11.0 Oct 2, 2018
cubells pushed a commit to Tecnativa/interface-github that referenced this pull request Apr 5, 2019
@StephanRozendaal @cubells
icon from manifest (OCA#23)
2e767c3 
* [FIX]  Fix field property

The property is 'readony'.

* [IMP]Get module icon from multiple sources

Get the module icon from the following sources (in order):
 1. From the first entry of the images tag from the manifest
 2. From the static directory
Tardo pushed a commit to Tecnativa/interface-github that referenced this pull request Apr 14, 2020
@StephanRozendaal @Tardo
icon from manifest (OCA#23)
30494b5 
* [FIX]  Fix field property

The property is 'readony'.

* [IMP]Get module icon from multiple sources

Get the module icon from the following sources (in order):
 1. From the first entry of the images tag from the manifest
 2. From the static directory
Tardo pushed a commit to Tecnativa/interface-github that referenced this pull request Jun 17, 2020
@StephanRozendaal @Tardo
icon from manifest (OCA#23)
278d62d 
* [FIX]  Fix field property

The property is 'readony'.

* [IMP]Get module icon from multiple sources

Get the module icon from the following sources (in order):
 1. From the first entry of the images tag from the manifest
 2. From the static directory
pedrobaeza pushed a commit to Tecnativa/interface-github that referenced this pull request Jun 18, 2020
@StephanRozendaal @pedrobaeza
icon from manifest (OCA#23)
083d1a4 
* [FIX]  Fix field property

The property is 'readony'.

* [IMP]Get module icon from multiple sources

Get the module icon from the following sources (in order):
 1. From the first entry of the images tag from the manifest
 2. From the static directory
OpenCode pushed a commit to OpenCode/interface-github that referenced this pull request Jul 15, 2021
@StephanRozendaal @OpenCode
icon from manifest (OCA#23)
aefbced 
* [FIX]  Fix field property

The property is 'readony'.

* [IMP]Get module icon from multiple sources

Get the module icon from the following sources (in order):
 1. From the first entry of the images tag from the manifest
 2. From the static directory
ernestotejeda pushed a commit to Tecnativa/interface-github that referenced this pull request Jul 30, 2021
@StephanRozendaal
icon from manifest (OCA#23)
1d507e3 
* [FIX]  Fix field property

The property is 'readony'.

* [IMP]Get module icon from multiple sources

Get the module icon from the following sources (in order):
 1. From the first entry of the images tag from the manifest
 2. From the static directory
OpenCode pushed a commit to OpenCode/interface-github that referenced this pull request Jun 23, 2022
@StephanRozendaal @OpenCode
icon from manifest (OCA#23)
1ef67d2 
* [FIX]  Fix field property

The property is 'readony'.

* [IMP]Get module icon from multiple sources

Get the module icon from the following sources (in order):
 1. From the first entry of the images tag from the manifest
 2. From the static directory
victoralmau pushed a commit to Tecnativa/interface-github that referenced this pull request Nov 17, 2022
@StephanRozendaal @victoralmau
icon from manifest (OCA#23)
0c929d2 
* [FIX]  Fix field property

The property is 'readony'.

* [IMP]Get module icon from multiple sources

Get the module icon from the following sources (in order):
 1. From the first entry of the images tag from the manifest
 2. From the static directory
carolinafernandez-tecnativa pushed a commit to Tecnativa/interface-github that referenced this pull request Jan 9, 2024
@StephanRozendaal @carolinafernandez-tecnativa
icon from manifest (OCA#23)
00747fc 
* [FIX]  Fix field property

The property is 'readony'.

* [IMP]Get module icon from multiple sources

Get the module icon from the following sources (in order):
 1. From the first entry of the images tag from the manifest
 2. From the static directory
carolinafernandez-tecnativa pushed a commit to Tecnativa/interface-github that referenced this pull request Mar 7, 2024
@StephanRozendaal @carolinafernandez-tecnativa
icon from manifest (OCA#23)
2958ced 
* [FIX]  Fix field property

The property is 'readony'.

* [IMP]Get module icon from multiple sources

Get the module icon from the following sources (in order):
 1. From the first entry of the images tag from the manifest
 2. From the static directory
victoralmau pushed a commit to Tecnativa/interface-github that referenced this pull request Nov 8, 2024
@StephanRozendaal @victoralmau
icon from manifest (OCA#23)
65fe336 
* [FIX]  Fix field property

The property is 'readony'.

* [IMP]Get module icon from multiple sources

Get the module icon from the following sources (in order):
 1. From the first entry of the images tag from the manifest
 2. From the static directory
victoralmau pushed a commit to Tecnativa/interface-github that referenced this pull request Nov 11, 2024
@StephanRozendaal @victoralmau
icon from manifest (OCA#23)
c15c1b8 
* [FIX]  Fix field property

The property is 'readony'.

* [IMP]Get module icon from multiple sources

Get the module icon from the following sources (in order):
 1. From the first entry of the images tag from the manifest
 2. From the static directory
carlos-lopez-tecnativa pushed a commit to Tecnativa/interface-github that referenced this pull request May 20, 2025
@StephanRozendaal @carlos-lopez-tecnativa
icon from manifest (OCA#23)
5e7956f 
* [FIX]  Fix field property

The property is 'readony'.

* [IMP]Get module icon from multiple sources

Get the module icon from the following sources (in order):
 1. From the first entry of the images tag from the manifest
 2. From the static directory
carlos-lopez-tecnativa pushed a commit to Tecnativa/interface-github that referenced this pull request May 21, 2025
@StephanRozendaal @carlos-lopez-tecnativa
icon from manifest (OCA#23)
efead01 
* [FIX]  Fix field property

The property is 'readony'.

* [IMP]Get module icon from multiple sources

Get the module icon from the following sources (in order):
 1. From the first entry of the images tag from the manifest
 2. From the static directory
juppe pushed a commit to ahkio/interface-github that referenced this pull request Dec 15, 2025
@StephanRozendaal @juppe
icon from manifest (OCA#23)
8b8e25a 
* [FIX]  Fix field property

The property is 'readony'.

* [IMP]Get module icon from multiple sources

Get the module icon from the following sources (in order):
 1. From the first entry of the images tag from the manifest
 2. From the static directory
juppe pushed a commit to ahkio/interface-github that referenced this pull request Dec 15, 2025
@StephanRozendaal @juppe
icon from manifest (OCA#23)
aea980f 
* [FIX]  Fix field property

The property is 'readony'.

* [IMP]Get module icon from multiple sources

Get the module icon from the following sources (in order):
 1. From the first entry of the images tag from the manifest
 2. From the static directory
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers

@bizzappdev bizzappdev bizzappdev approved these changes

@elicoidal elicoidal elicoidal approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

needs review

Projects

None yet

Milestone

11.0

Development

Successfully merging this pull request may close these issues.

4 participants

@StephanRozendaal @bizzappdev @elicoidal @pedrobaeza