Skip to content

Conversation

@JordiMForgeFlow
Copy link
Contributor

@JordiMForgeFlow JordiMForgeFlow commented Oct 24, 2024

etobella and others added 30 commits January 15, 2025 10:53
Being used in some places like OCA/l10n-spain for a while
auth_type is mandatory.
so that it gets incorporated in the autogenerated README
Currently translated at 100.0% (4 of 4 strings)

Translation: edi-framework-16.0/edi-framework-16.0-edi_webservice_oca
Translate-URL: https://translation.odoo-community.org/projects/edi-framework-16-0/edi-framework-16-0-edi_webservice_oca/it/
@JordiMForgeFlow JordiMForgeFlow force-pushed the 18.0-mig-edi_webservice_oca branch 2 times, most recently from 290dd8a to 9df29e6 Compare January 15, 2025 10:25
@JordiMForgeFlow JordiMForgeFlow force-pushed the 18.0-mig-edi_webservice_oca branch from 9df29e6 to 5b12812 Compare January 15, 2025 11:20
Copy link
Contributor

@MiquelRForgeFlow MiquelRForgeFlow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be nicer to have this also in 17.0 (we are not Akretion hehe)

Copy link
Contributor

@LoisRForgeFlow LoisRForgeFlow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code review, LGTM

@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

Copy link

@JoanSForgeFlow JoanSForgeFlow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review, LGTM!

@JordiMForgeFlow
Copy link
Contributor Author

@etobella @simahawk could we get a review here? Thank you! :)

@JordiMForgeFlow
Copy link
Contributor Author

@simahawk could we also merge this one? :)

Copy link
Member

@etobella etobella left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

This PR looks fantastic, let's merge it!
Prepared branch 18.0-ocabot-merge-pr-117-by-etobella-bump-nobump, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit 0b9af72 into OCA:18.0 Mar 18, 2025
6 of 7 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at aa9f6de. Thanks a lot for contributing to OCA. ❤️

@MiquelRForgeFlow MiquelRForgeFlow deleted the 18.0-mig-edi_webservice_oca branch March 19, 2025 10:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.