-
Notifications
You must be signed in to change notification settings - Fork 75
Standardize on "Description" as discussed on Slack #66
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
specification/structure.md
Outdated
|
||
An OpenAPI document is a text file, commonly called `openapi.json` or `openapi.yaml`, representing a [JSON](https://en.wikipedia.org/wiki/JSON) object, in either JSON or [YAML](https://en.wikipedia.org/wiki/YAML) format. This file is called the **root document** and it can be split into multiple JSON or YAML files, for clarity. | ||
OpenAPI Descriptions are written as one or more text documents, commonly called `openapi.json` or `openapi.yaml`, representing a [JSON](https://en.wikipedia.org/wiki/JSON) object, in either JSON or [YAML](https://en.wikipedia.org/wiki/YAML) format. This document is called the **root document**. An OAD can consist solely of a root document, or it can be split into multiple documents for clarity. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"one or more text documents" and "commonly called openapi.json
" is a bit confusing.
Maybe first introduce the "entry document" and say that "the entry document is commonly called ..."
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ralfhandl thanks, will do- this goes better with the "root OpenAPI document" -> "entry OpenAPI document" change in the other PRs, too.
The learn site previously decided to use OpenAPI Description, but hedged with terms like "OpenAPI Description document" and often reverted to "OpenAPI document" in the text. A recent discussion on Slack finally revealed a consensus that * Re-defining "document" away from its intuitive meaning as a single coherent thing (file or network resource) is confusing * "description" has more support than "definition" or "document" Following up on that discussion, this change standardizes on: * "OpenAPI Description" as the term for the logical entity * "OAD" as a standardized abbreviation, alongside OAS and OAI * "document" to mean either local file or network resource * "documentation" only refers to generated or hand-written docs
Co-authored-by: Ralf Handl <[email protected]>
Also try to explain single vs multi documents and JSON objects, and the relationship of documents, references, and OADs, more clearly.
4b5fbdc
to
76df55d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
The learn site previously decided to use OpenAPI Description, but hedged with terms like "OpenAPI Description document" and often reverted to "OpenAPI document" in the text.
A recent discussion on Slack finally revealed a consensus that
Following up on that discussion, this change standardizes on:
I'd like to add a glossary as well to clarify this, acknowledge the history, and clarify a few other bits of terminology, but I will do that in a follow-up PR if this PR or something like it gets accepted.
See also PR OAI/OpenAPI-Specification#3384 (3.0.4) and PR OAI/OpenAPI-Specification#3385 (3.1.1)