Skip to content

Standardize on "Description" as discussed on Slack #66

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Oct 1, 2023

Conversation

handrews
Copy link
Member

The learn site previously decided to use OpenAPI Description, but hedged with terms like "OpenAPI Description document" and often reverted to "OpenAPI document" in the text.

A recent discussion on Slack finally revealed a consensus that

  • Re-defining "document" away from its intuitive meaning as a single coherent thing (file or network resource) is confusing
  • "description" has more support than "definition" or "document"

Following up on that discussion, this change standardizes on:

  • "OpenAPI Description" as the term for the logical entity
  • "OAD" as a standardized abbreviation, alongside OAS and OAI
  • "document" to mean either local file or network resource (mostly avoiding "file", although I could go either way on that)
  • "documentation" only refers to generated or hand-written docs

I'd like to add a glossary as well to clarify this, acknowledge the history, and clarify a few other bits of terminology, but I will do that in a follow-up PR if this PR or something like it gets accepted.

See also PR OAI/OpenAPI-Specification#3384 (3.0.4) and PR OAI/OpenAPI-Specification#3385 (3.1.1)


An OpenAPI document is a text file, commonly called `openapi.json` or `openapi.yaml`, representing a [JSON](https://en.wikipedia.org/wiki/JSON) object, in either JSON or [YAML](https://en.wikipedia.org/wiki/YAML) format. This file is called the **root document** and it can be split into multiple JSON or YAML files, for clarity.
OpenAPI Descriptions are written as one or more text documents, commonly called `openapi.json` or `openapi.yaml`, representing a [JSON](https://en.wikipedia.org/wiki/JSON) object, in either JSON or [YAML](https://en.wikipedia.org/wiki/YAML) format. This document is called the **root document**. An OAD can consist solely of a root document, or it can be split into multiple documents for clarity.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"one or more text documents" and "commonly called openapi.json" is a bit confusing.

Maybe first introduce the "entry document" and say that "the entry document is commonly called ..."

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ralfhandl thanks, will do- this goes better with the "root OpenAPI document" -> "entry OpenAPI document" change in the other PRs, too.

handrews and others added 3 commits September 29, 2023 12:50
The learn site previously decided to use OpenAPI Description, but
hedged with terms like "OpenAPI Description document" and often
reverted to "OpenAPI document" in the text.

A recent discussion on Slack finally revealed a consensus that

* Re-defining "document" away from its intuitive meaning as a single
  coherent thing (file or network resource) is confusing
* "description" has more support than "definition" or "document"

Following up on that discussion, this change standardizes on:

* "OpenAPI Description" as the term for the logical entity
* "OAD" as a standardized abbreviation, alongside OAS and OAI
* "document" to mean either local file or network resource
* "documentation" only refers to generated or hand-written docs
Also try to explain single vs multi documents and JSON objects,
and the relationship of documents, references, and OADs,
more clearly.
Copy link
Member

@MikeRalphson MikeRalphson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@MikeRalphson MikeRalphson merged commit cbd45e0 into OAI:main Oct 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants