-
Notifications
You must be signed in to change notification settings - Fork 9.1k
Ensure that array always have "items" attribute. #413
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
It passing all JS test, but fails somewhere inside Scala tests. |
@IvanGoncharov - thanks, I'll review it and the tests. If the change is good, I'll work on the tests. It'll take a while though. |
I review Scala tests and they are very simple. |
Knowing the library's author, I also know the project is not abandoned. |
So how about moving these test into https://github.com/swagger-api/swagger-spec/blob/master/test/validate.js ? |
Sure, but unfortunately it would take me a while to review it. |
I understand. |
Thanks! |
@IvanGoncharov - any update on this? |
@webron Just started migrated tests. |
@IvanGoncharov - closing this for now. Really trying to minimize changes to things related to 2.0. |
Implement based on comments from #404