Non-string discriminator values have undefined behavior (3.0.4) #3728
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The "undefined" wording was chosen to allow implementations that make a good-faith effort to accommodate non-string values to remain compliant. However, new implementations are not expected to implement any sort of type coersion, and this guides API designers away from that expectation.
handrews
added
discriminator
clarification
ralfhandl
reviewed
Apr 22, 2024
Co-authored-by: Ralf Handl <[email protected]>
ralfhandl
approved these changes
Apr 22, 2024
|
Since there are two TSC approvals here, I'm going to hit the merge button - the TSC emphasized again in today's TDC call that the 2nd TSC approver can merge, so I'm assuming I can merge with 2 TSC approvals. |
lornajane
added a commit
that referenced
this pull request
May 1, 2024
Non-string discriminator values (3.1.1 port of #3728)
lornajane
added a commit
that referenced
this pull request
May 1, 2024
Non-string discriminator values (3.2.0 port of #3728)
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The "undefined" wording was chosen to allow implementations that make a good-faith effort to accommodate non-string values to remain compliant. However, new implementations are not expected to implement any sort of type coersion, and this guides API designers away from that expectation.
If accepted, I will port this to 3.1.1. For 3.2.0 we might either want to strengthen this to outright forbid non-strings or define a mapping for at least certain non-strings (e.g. booleans).