add description to all schemas #2802
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jdesrosiers
reviewed
Dec 1, 2021
|
ok, this might be a bit better now. |
karenetheridge
force-pushed
the
ether/describe-schemas
branch
from
d931c05 to
8ab4f97
Compare
jdesrosiers
suggested changes
Dec 6, 2021
schemas/v3.1/schema-base.yaml
Outdated
| @@ -1,3 +1,4 @@ | |||
| description: A dialect to use for schemas within OpenAPI documents | |||
There was a problem hiding this comment.
This isn't a dialect schema. It describes an OpenAPI document where the schemas all use the OpenAPI Schema dialect.
karenetheridge
force-pushed
the
ether/describe-schemas
branch
from
8ab4f97 to
5f8dff8
Compare
darrelmiller
approved these changes
Dec 23, 2021
jdesrosiers
suggested changes
Feb 10, 2022
There was a problem hiding this comment.
One of the descriptions is not quite right. In case it's still unclear what that schema is for, there's a better description here, https://json-schema.org/blog/posts/validating-openapi-and-json-schema
karenetheridge
force-pushed
the
ether/describe-schemas
branch
2 times, most recently
from
175e688 to
6259423
Compare
|
done. |
jdesrosiers
suggested changes
Feb 12, 2022
karenetheridge
force-pushed
the
ether/describe-schemas
branch
from
834722a to
6f1c55b
Compare
jdesrosiers
approved these changes
Feb 14, 2022
in v3.1 the number of schemas increased considerably, which can be a bit confusing.
karenetheridge
force-pushed
the
ether/describe-schemas
branch
from
6f1c55b to
12bc151
Compare
|
Thanks for all the effort, @karenetheridge, and @jdesrosiers for the additional reviews! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
in v3.1 the number of schemas increased considerably, which can be a bit confusing.