Make callback example link relative #1223
Conversation
versions/3.0.md
Outdated
| @@ -1820,7 +1820,7 @@ The key value used to identify the callback object is an expression, evaluated a | |||
| ##### Patterned Fields | |||
| Field Pattern | Type | Description | |||
| ---|:---:|--- | |||
| <a name="callbackExpression"></a>{expression} | [Path Item Object](#pathItemObject) | A Path Item Object used to define a callback request and expected responses. A [complete example](https://github.com/OAI/OpenAPI-Specification/blob/OpenAPI.next/examples/v3.0/callback-example.yaml) is available. | |||
| <a name="callbackExpression"></a>{expression} | [Path Item Object](#pathItemObject) | A Path Item Object used to define a callback request and expected responses. A [complete example](/examples/v3.0/callback-example.yaml) is available. | |||
There was a problem hiding this comment.
Doesn't that need a .. at the front of that URL?
There was a problem hiding this comment.
Seems to work ok in my fork, i.e. it's a repo-root relative url.
There was a problem hiding this comment.
I guess the difference is that with the .. it points to the example in the current branch, without it points to master (where this file doesn't exist yet).
There was a problem hiding this comment.
The link in my fork points to https://github.com/OAI/OpenAPI-Specification/blob/OpenAPI.next/examples/v3.0/callback-example.yaml - not the master branch? Viewing the changes I see a link to the commit blob
There was a problem hiding this comment.
Hmm, I looked at it in the differences view, and there it pointed to https://github.com/OAI/OpenAPI-Specification/blob/master/examples/v3.0/callback-example.yaml. Strangely, if I open the same address again in a new browser tab, it now points to https://github.com/OAI/OpenAPI-Specification/blob/rel_link/examples/v3.0/callback-example.yaml. (Both links give 404s currently, the second one uses your branch name with the main fork's repository name.)
I guess Github it not that predictable with the link expansion.
There was a problem hiding this comment.
Thanks @ePaul for looking at it again. Let's try it with the ..
Saves having to remember to update it later.