-
-
Notifications
You must be signed in to change notification settings - Fork 637
fix::notion-client - Replace ky
with ofetch
|| fix::react-notion-x - LazyImageFull.tsx updated
#646
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
The latest updates on your projects. Learn more about Vercel for GitHub.
|
@mustaqimarifin collections are no longer loading: https://react-notion-x-minimal-demo-5sgdlsrby-saasify.vercel.app/9cb9716c93164c6c8b4cd0bac3879aeb |
i think the minimal demo doesn't import 'Collections', but the full demo does? Because the full demo does indeed load Collections on my end. Thx Left: Current React-Notion-X Test Suite || Right: Localhost s22.mp4 |
true, double checked and all good on the full example including my personal problematic page |
@transitive-bullshit can we merge this too? |
@transitive-bullshit kind reminder :) |
any update? |
there are too many unrelated changes to merge this PR. #653 was the main fix for collection issues |
i'm really hesitant to switch from |
totally understand. tbf, i tested it with native fetch and it works just as well. I'm not sure whats causing KY to stall out.. |
I also met this problem with NextJS App Router. #657 shows the details. |
…ocal dependencies. (Fix) Replace KY with OFetch. (Fix) Cleaned up unnceccesary and erroneous changes
Hi all @transitive-bullshit @rimonhanna @Euruson @zsolteszku , Yes, apologies for the messy PR. I've rebased the PR from the latest master with just the additions as originally intended. Happy to help if possible. |
Thanks @mustaqimarifin 🙏 Will get a version of this released soon. Should fix #657 and possibly #665 cc @tomcerdeira |
ky
with got
|| fix::react-notion-x - LazyImageFull.tsx updatedky
with ofetch
|| fix::react-notion-x - LazyImageFull.tsx updated
Description
Replaced
KY
withGOT
React Lazy Images
react-lazy-images
and placed updated code and types incomponents/lazy-images-full.tsx
react-intersection-observer
andunionize
Notion Test Page ID
Can test with a local build of this fork with the examples in the monorepo.