Type safety #12
Draft
Type safety #12
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
thank you very much for your work on this package. It's been my favorite animation add-on since its very first version years ago!
I've been thinking about a little revamp of the API in order to make it more sound at compile-time.
It leverages tags/keys that are generics on the animation type they want to represent, so that it's guaranteed that you can only add animatables (for example tweens) of the given tag type and also extract values of the animatable while using them for the animation at a later time.
I'll submit this as a draft PR because, if you like the approach, some work needs to be done in order to handle backward compatibility and reword the docs.