Skip to content

Conversation

@Wodann
Copy link
Member

@Wodann Wodann commented May 26, 2025

@Wodann Wodann requested review from Copilot and frangio May 26, 2025 12:02
@Wodann Wodann self-assigned this May 26, 2025
@changeset-bot
Copy link

changeset-bot bot commented May 26, 2025

🦋 Changeset detected

Latest commit: 860b6dc

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
@ignored/edr Patch
@nomicfoundation/edr-helpers Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@Wodann Wodann temporarily deployed to github-action-benchmark May 26, 2025 12:02 — with GitHub Actions Inactive
@Wodann Wodann temporarily deployed to github-action-benchmark May 26, 2025 12:02 — with GitHub Actions Inactive
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR refactors the code to rename “snapshot” to “state snapshot” as part of a backport. Key changes include renaming variables, functions, and types from “snapshot” to “state_snapshot”, updating associated documentation, and adjusting references in cheatcodes and tests.

Reviewed Changes

Copilot reviewed 13 out of 24 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
crates/foundry/evm/core/src/fork/database.rs Renamed snapshot-related fields and methods to their state snapshot counterparts.
crates/foundry/evm/core/src/backend/snapshot.rs Updated snapshot types and actions to the new state snapshot variants.
crates/foundry/evm/core/src/backend/mod.rs Replaced snapshot operations with state snapshot operations with minor doc updates.
crates/foundry/evm/core/src/backend/in_memory_db.rs Updated field name from snapshots to state_snapshots.
crates/foundry/evm/core/src/backend/cow.rs Adjusted snapshot method calls to state snapshot equivalents.
crates/foundry/cheatcodes/src/evm.rs Renamed cheatcode functions and inner helpers for snapshot operations.
crates/cheatcodes/spec/src/vm.rs Updated cheatcode interface methods and deprecation annotations accordingly.
crates/edr_solidity_tests/tests/it/repros.rs Updated test name to reflect new revert method naming.
.changeset/long-eagles-thank.md Updated changeset note to document the deprecation and renaming of snapshot cheatcodes.
Files not reviewed (11)
  • crates/edr_solidity_tests/tests/testdata/cheats/Vm.sol: Language not supported
  • crates/edr_solidity_tests/tests/testdata/default/cheats/Prevrandao.t.sol: Language not supported
  • crates/edr_solidity_tests/tests/testdata/default/cheats/Snapshots.t.sol: Language not supported
  • crates/edr_solidity_tests/tests/testdata/default/cheats/StateSnapshots.t.sol: Language not supported
  • crates/edr_solidity_tests/tests/testdata/default/cheats/loadAllocs.t.sol: Language not supported
  • crates/edr_solidity_tests/tests/testdata/default/repros/Issue2984.t.sol: Language not supported
  • crates/edr_solidity_tests/tests/testdata/default/repros/Issue3055.t.sol: Language not supported
  • crates/edr_solidity_tests/tests/testdata/default/repros/Issue3792.t.sol: Language not supported
  • crates/edr_solidity_tests/tests/testdata/default/repros/Issue6355.t.sol: Language not supported
  • crates/foundry/cheatcodes/assets/cheatcodes.json: Language not supported
  • crates/foundry/cheatcodes/assets/cheatcodes.schema.json: Language not supported
Comments suppressed due to low confidence (1)

crates/foundry/evm/core/src/backend/mod.rs:92

  • There is a typo in the documentation: "napshots" should be spelled "snapshots".
/// A state snapshot is associated with a new unique id that's created for

@Wodann Wodann temporarily deployed to github-action-benchmark May 26, 2025 12:51 — with GitHub Actions Inactive
@Wodann Wodann temporarily deployed to github-action-benchmark May 26, 2025 12:51 — with GitHub Actions Inactive
@Wodann Wodann temporarily deployed to github-action-benchmark May 26, 2025 12:53 — with GitHub Actions Inactive
@Wodann Wodann had a problem deploying to github-action-benchmark May 26, 2025 15:27 — with GitHub Actions Error
@Wodann Wodann had a problem deploying to github-action-benchmark May 26, 2025 15:27 — with GitHub Actions Error
@Wodann Wodann force-pushed the refactor/snapshot-name branch from be1aa6d to d4a7935 Compare May 26, 2025 15:29
@Wodann Wodann temporarily deployed to github-action-benchmark May 26, 2025 15:30 — with GitHub Actions Inactive
@Wodann Wodann temporarily deployed to github-action-benchmark May 26, 2025 15:30 — with GitHub Actions Inactive
@Wodann Wodann temporarily deployed to github-action-benchmark May 26, 2025 16:34 — with GitHub Actions Inactive
@Wodann Wodann temporarily deployed to github-action-benchmark May 26, 2025 16:34 — with GitHub Actions Inactive
@Wodann Wodann temporarily deployed to github-action-benchmark May 26, 2025 16:35 — with GitHub Actions Inactive
@Wodann Wodann force-pushed the feat/deprecate-cheatcode branch from 1d230af to 7f34517 Compare May 26, 2025 17:26
Base automatically changed from feat/deprecate-cheatcode to feat/solidity-tests May 26, 2025 21:28
@Wodann Wodann force-pushed the refactor/snapshot-name branch from d4a7935 to dbf7021 Compare May 26, 2025 21:34
@Wodann Wodann had a problem deploying to github-action-benchmark May 26, 2025 21:34 — with GitHub Actions Error
@Wodann Wodann had a problem deploying to github-action-benchmark May 26, 2025 21:34 — with GitHub Actions Error
@Wodann Wodann temporarily deployed to github-action-benchmark May 26, 2025 21:36 — with GitHub Actions Inactive
@Wodann Wodann temporarily deployed to github-action-benchmark May 26, 2025 21:36 — with GitHub Actions Inactive
@Wodann Wodann temporarily deployed to github-action-benchmark May 26, 2025 22:36 — with GitHub Actions Inactive
@Wodann Wodann had a problem deploying to github-action-benchmark May 26, 2025 22:36 — with GitHub Actions Failure
@Wodann Wodann temporarily deployed to github-action-benchmark May 26, 2025 22:38 — with GitHub Actions Inactive
@Wodann Wodann had a problem deploying to github-action-benchmark May 27, 2025 08:04 — with GitHub Actions Failure
@Wodann Wodann temporarily deployed to github-action-benchmark May 27, 2025 08:40 — with GitHub Actions Inactive
@Wodann
Copy link
Member Author

Wodann commented May 27, 2025

Hardhat tests are known to be failing on main (see failing CI job)

@Wodann Wodann merged commit 3910948 into feat/solidity-tests May 27, 2025
38 of 41 checks passed
@Wodann Wodann deleted the refactor/snapshot-name branch May 27, 2025 09:04
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 26, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants