Merge from original repo #1
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The methods on GraphqlErrorBuilder each contain [an assertion that the supplied data is non-null](https://github.com/graphql-java/graphql-java/blob/master/src/main/java/graphql/GraphqlErrorBuilder.java#L77), but it is not required that these elements be non-null on every throw GraphQLError. For example, errors often omit a `path` property, which will lead to an unhandled `graphql.AssertException` when the error is handled by `GraphQLErrorFromExceptionHandler.java`.
If numExpectedResponses was 0 or negative, the method did not work according to documentation, it did not wait out the specified amount of time as the condition in await() was fulfilled immediately. This resulted in waitAndExpectNoResponse and awaitAndGetAllResponses not working as specified in the documentation. The test suite was also updated to catch this issue in the future.
Adding details on how to add GraphQL Playground starter
Removing references to JCenter now that it's on the way out
…-test-waiting fix: test subscription not waiting the specified amount of time
Tidy up
…ebflux Feature/fix playground webflux
feat: add Maven BOM for the project
Only call GraphqlErrorBuilder with non-null data
Upgrade some dependencies to the latest versions
…-245 Update to use spring-boot 2.4.5
Updating documentation to latest cdn version
…playOptions, hideDocs, hideSettings)
…ptions and default behaviour
…atest Voyager configuration options
…verify-google-code-format # Conflicts: # voyager-spring-boot-autoconfigure/src/main/java/graphql/kickstart/voyager/boot/VoyagerIndexHtmlTemplate.java
…o-16 ci: update Java 15 to Java 16 in pull request workflow
…ould notify users that this plugin is required
…e-format Verify google code format
Extracting gradle dependency versions to gradle.properties and making property name consistent
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Merge from original repo