Skip to content
This repository was archived by the owner on Dec 19, 2023. It is now read-only.

Playground incompatible with Spring Webflux #487

Closed
ooga opened this issue Dec 14, 2020 · 3 comments · Fixed by #521
Closed

Playground incompatible with Spring Webflux #487

ooga opened this issue Dec 14, 2020 · 3 comments · Fixed by #521
Labels
bug
Milestone
11.1.0

Comments

@ooga
Copy link

ooga commented Dec 14, 2020

Describe the bug
When we add playground-spring-boot-starter in a spring webflux project, the project is instantiated as spring mvc and served with Tomcat

Because playground-spring-boot-starter require spring-boot-starter-web

To Reproduce
Steps to reproduce the behavior:

  1. include these dependencies
    • graphql-kickstart-spring-boot-starter-webflux
    • playground-spring-boot-starter

Expected behavior
Project is served with Netty and the playground is accessible
@ooga ooga added the bug label Dec 14, 2020
BlasiusSecundus added a commit to BlasiusSecundus/graphql-spring-boot that referenced this issue Dec 19, 2020
@BlasiusSecundus
fix(graphql-java-kickstart#487): Playground integration not working w…
ce1d6f9 
…hen using WebFlux
BlasiusSecundus added a commit to BlasiusSecundus/graphql-spring-boot that referenced this issue Dec 19, 2020
@BlasiusSecundus
fix(graphql-java-kickstart#487): Playground integration not working w…
1fe41cc 
…hen using WebFlux
@BlasiusSecundus
Copy link

The Playgound integration is currently not working with WebFlux.

I have a WIP fix for the issue, see the linked commit. It seems to work properly but additional tests would be needed (only tested with the bundled webflux sample).

@BlasiusSecundus BlasiusSecundus mentioned this issue Dec 30, 2020
Closed
BlasiusSecundus added a commit to BlasiusSecundus/graphql-spring-boot that referenced this issue Dec 30, 2020
@BlasiusSecundus
fix(graphql-java-kickstart#487): Playground integration not working w…
a22d75f 
…hen using WebFlux
BlasiusSecundus added a commit to BlasiusSecundus/graphql-spring-boot that referenced this issue Dec 30, 2020
@BlasiusSecundus
fix(graphql-java-kickstart#487): additional Playground WebFlux tests
c37ec20
BlasiusSecundus added a commit to BlasiusSecundus/graphql-spring-boot that referenced this issue Jan 25, 2021
@BlasiusSecundus
fix(graphql-java-kickstart#487): Playground integration not working w…
957ddc0 
…hen using WebFlux
BlasiusSecundus added a commit to BlasiusSecundus/graphql-spring-boot that referenced this issue Jan 25, 2021
@BlasiusSecundus
fix(graphql-java-kickstart#487): additional Playground WebFlux tests
1b93759
BlasiusSecundus added a commit to BlasiusSecundus/graphql-spring-boot that referenced this issue Jan 25, 2021
@BlasiusSecundus
fix(graphql-java-kickstart#487): csrf is now supported with Playgroun…
6be4a07 
…d on Webflux
@varunsufi
Copy link

Is it something blocking here ? Can we merge the proposed solution ?

@BlasiusSecundus
Copy link

I planned to do some more testing before finalizing the MR but time passes faster than expected... I opened it up to review so that it is not blocked anymore on my side. Help with testing with different setups / feedback is of course appreciated.

@oliemansm oliemansm added this to the 11.1.0 milestone May 14, 2021
@oliemansm oliemansm linked a pull request May 14, 2021 that will close this issue
Feature/fix playground webflux #521
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
11.1.0
Development

Successfully merging a pull request may close this issue.

Feature/fix playground webflux BlasiusSecundus/graphql-spring-boot
4 participants
@ooga @varunsufi @oliemansm @BlasiusSecundus