Add O_BINARY flag when opening files to allow compilation for Windows #372
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mic92
reviewed
Apr 7, 2022
|
Thanks. It might make sense to add mingw as a target to the CI to avoid future breakage in future. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello!
Thank you for maintaining this tool. We've been using it at Guardsquare for a while and have recently identified a use-case where we would also need to run it on Windows hosts.
This could be achieved by switching the compiler to MinGW-w64. However, when opening the ELF file for reading/writing the code currently does not pass the
O_BINARYflag. If the flag is not passed on Windows, the file is opened in text mode and reading/writing may prematurely end due to misinterpretation of file contents.This pull request resolves this issue by:
O_BINARYas0if it isn't defined, so that it has no effect on systems that do not have theO_BINARYflag.O_BINARYwhen opening the ELF file for reading/writing.Thank you for taking the time to look at this.
Best Regards,
Jago