Add zsh completion support

[Y7n05h]

I found that patchelf lacks shell completion support.
I am willing to write zsh completion scripts for patchelf. If it’s acceptable, I’m happy to send a Pull Request

[Mic92]

Sure go ahead. Here is an example on how to install bash completion with automake https://github.com/scop/bash-completion/blob/5677f33a36159e81a9ff3adf423df74090f1364a/completions/Makefile.am#L481

[Y7n05h]

Sure go ahead. Here is an example on how to install bash completion with automake https://github.com/scop/bash-completion/blob/5677f33a36159e81a9ff3adf423df74090f1364a/completions/Makefile.am#L481

I have encountered some problems. Because the parameter order of patchelf is:

patchelf [--set-interpreter FILENAME] [--page-size SIZE] [--print-interpreter] [--print-soname] [--set-soname SONAME] [--set-rpath RPATH] [--remove-rpath] [--shrink-rpath] [--allowed-rpath-prefixes PREFIXES] [--print-rpath] [--force-rpath] [--add-needed LIBRARY] [--remove-needed LIBRARY] [--replace-needed LIBRARY NEW_LIBRARY] [--print-needed] [--no-default-lib] [--clear-symbol-version SYMBOL] [--output FILE] [--debug] [--version] FILENAME...
This syntax causes inconvenience for Shell completion.

E.g:

patchelf --replace-needed libc.so.6 ~/libcs/libs/libc-2.27.so example

When I enter patchelf --replace-needed, I expect to be able to complete the library in the file specified by FILENAME, but FILENAME has not been entered yet.

If you can change the syntax of patchelf, put FILENAME after patchelf.

patchelf FILENAME [--set-interpreter FILENAME] [--page-size SIZE] [--print-interpreter] [--print-soname] [--set-soname SONAME] [--set-rpath RPATH] [--remove-rpath] [--shrink-rpath] [--allowed-rpath-prefixes PREFIXES] [--print-rpath] [--force-rpath] [--add-needed LIBRARY] [--remove-needed LIBRARY] [--replace-needed LIBRARY NEW_LIBRARY] [--print-needed] [--no-default-lib] [--clear-symbol-version SYMBOL] [--output FILE] [--debug] [--version]

After the change, Zsh can provide completion information for --replace-needed based on the file specified by FILENAME.

Currently patchelf example --replace-needed libc.so.6 ~/libcs/libs/libc-2.27.so runs normally on patchelf 0.12.

I want to know whether the syntax of putting FILENAME in patchelf can achieve the same result as the original syntax in all cases.

[Mic92]

I see the issue. Changing the order however would break with a lot of users in the name of zsh completion. Is it not just possible to just leave out exact filename completion for now? Or are talking about updating documentation here?

[Y7n05h]

In my simple test, I found that patchelf 0.12 works normally under these two different orders.
We probably only need to tell the user that these two orders are correct by changing the document and the output of pathelf --help. Users only need to use any order they like.

[Mic92]

Before spending too much time on the implementation, maybe just open a work-in-progress PR.
I don't think we need to explicitly mention both ways as they will either stick to the documented one or use the other way around by accident - the zsh completion could just cover both ways if that is possible.

[Freed-Wu]

Any progress about this issue?

[Y7n05h]

Any progress about this issue?

I am so sorry. I didn't continue to work on it. I haven't been using patchelf for a long time.