nix-profile{,-daemon}.fish: set NIX_PROFILES to use $NIX_LINK #14293
+2
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ryota2357
force-pushed
the
fix-fish-nix-profiles-use-nix-link
branch
from
c032dcb to
d5f4653
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
In the fish scripts,
NIX_PROFILESis currently set to... $HOME/.nix-profile, even though the scripts computeNIX_LINK(respectingXDG_STATE_HOME).The sh equivalents already export:
nix/scripts/nix-profile.sh.in
Line 37 in ad2360c
nix/scripts/nix-profile-daemon.sh.in
Line 31 in ad2360c
To keep fish in sync with sh behavior and respect XDG, I changed to using
$NIX_LINKin fish.Context
This is related to point 5 in #9441
Add 👍 to pull requests you find important.
The Nix maintainer team uses a GitHub project board to schedule and track reviews.