Skip to content

ci(linter): update go linter to 1.39 #104

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Mar 28, 2021
Merged

Conversation

Nivl
Copy link
Owner

@Nivl Nivl commented Mar 27, 2021

  • Update golangci-lint to latest version (v1.39)
  • Remove/Replace deprecated linters
  • Add new linters released with 1.38 and 1.39

/!\ Blocked until golangci/golangci-lint#1872 is merged

@Nivl Nivl changed the title update golangci-lint to 1.39 and add lnew linters ci(linter): update go linter to 1.39 Mar 27, 2021
@codecov
Copy link

codecov bot commented Mar 27, 2021

Codecov Report

Merging #104 (0608d84) into main (379bdff) will decrease coverage by 0.16%.
The diff coverage is 25.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #104      +/-   ##
==========================================
- Coverage   80.53%   80.36%   -0.17%     
==========================================
  Files          26       26              
  Lines        1464     1467       +3     
==========================================
  Hits         1179     1179              
- Misses        165      167       +2     
- Partials      120      121       +1     
Impacted Files Coverage Δ
backend/fsbackend/fsbackend.go 82.35% <ø> (ø)
backend/fsbackend/objects.go 74.32% <ø> (ø)
cmd/git-go/cat_file.go 74.25% <ø> (ø)
ginternals/object/commit.go 96.03% <ø> (ø)
ginternals/object/object.go 96.82% <ø> (ø)
ginternals/object/tag.go 95.12% <ø> (ø)
ginternals/object/tree.go 96.77% <ø> (ø)
ginternals/packfile/packfile.go 60.29% <ø> (ø)
ginternals/packfile/packindex.go 56.66% <ø> (ø)
repo.go 75.75% <ø> (ø)
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 379bdff...0608d84. Read the comment docs.

@Nivl Nivl marked this pull request as ready for review March 28, 2021 22:44
@Nivl Nivl changed the title ci(linter): update go linter to 1.39 ci(linter): update go linter to 1.39 Mar 28, 2021
@Nivl Nivl merged commit 649123c into main Mar 28, 2021
@Nivl Nivl deleted the ml/ci/linter/golangci-lint-1.39 branch March 28, 2021 22:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant