Skip to content

Conversation

devedse
Copy link
Contributor

@devedse devedse commented Aug 24, 2023

This should fix:
#3138

@jc21 up to you if this is the right way to fix it.

@nginxproxymanagerci
Copy link

Docker Image for build 2 is available on DockerHub as jc21/nginx-proxy-manager:github-pr-3155

Note: ensure you backup your NPM instance before testing this PR image! Especially if this PR contains database changes.

@jc21
Copy link
Member

jc21 commented Aug 31, 2023

Seems fine to me. Let me know if this image works for you.

@jc21 jc21 added the requires-verification Waiting for one or more people to confirm the fix label Aug 31, 2023
@devedse
Copy link
Contributor Author

devedse commented Aug 31, 2023

I'll give it a try. Do you know enough about certbot to be able to explain why my change is needed 😄 ?

@jc21
Copy link
Member

jc21 commented Sep 1, 2023

Well, no I don't know why not restoring the original TXT record would be the answer to this problem. I fully understand the DNS verifiction process, but I feel that the devs of the duckdns certbot might have a bug there.

@devedse
Copy link
Contributor Author

devedse commented Sep 1, 2023

I just tried it with the normal unchanged code (:latest image) and it works again... wtf... My guess is that DuckDNS can be in a specific corrupted state or something where we need need to not restore the OriginalTxtRecord???

image

It might still be good to merge this since it apparently can fix the issue.

@jc21 jc21 merged commit 3197de4 into NginxProxyManager:develop Oct 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
requires-verification Waiting for one or more people to confirm the fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants