fix: typescript transpilation / assertion error in 2.9.x #960
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks good! If you'd like to make more PRs of this type, please feel free to. I can cut a release either after this PR, or wait until you make additional changes. |
|
Released in 2.0.7. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Case in Point
Using
falcor@^2.0.6with Angular 6 with Typescript 2.9.2 when generating source maps fails with this message from Typescript transpilation:Error: Debug Failure. False expression.Issues fixed
Because of the
a = b = cstructure used below (inGetResponse.jsandSetResponse.js):var GetResponse = module.exports = function GetResponse(model, paths ...This triggers the following github issue: microsoft/TypeScript#24963.
As we are using Angular 6, it is undesirable to change Typescript versions, so i'm fixing the problem at the source. There are other areas where this pattern exists in the falcor codebase, but this is the minimal change to solve our immediate issue. Happy to update the other files if it's a requirement.
I have tested our Angular project with this branch and it works successfully.