Opportunity record #216
Opportunity record #216
Conversation
lib/netsuite/records/opportunity.rb
Outdated
| initialize_from_attributes_hash(attributes) | ||
| end | ||
|
|
||
| def self.search_class_name |
There was a problem hiding this comment.
No need for a search_Class_name here... this is auto-generated. This is only required when the search name is different from the class name.
jheth
force-pushed
the
opportunity-record
branch
3 times, most recently
from
4272c18 to
3932720
Compare
| @@ -0,0 +1,30 @@ | |||
| module NetSuite | |||
| module Records | |||
| class OpportunityItemList < Support::Sublist | |||
There was a problem hiding this comment.
@jheth OpportunityItemList shouldn't contain any logic aside a namespace definition and a sublist call. Ex:
netsuite/lib/netsuite/records/invoice_item_list.rb
Lines 4 to 6 in de60d36
|
Looking good! One additional comment: any new records should be added to the basic record spec: https://github.com/NetSweet/netsuite/blob/master/spec/netsuite/records/basic_record_spec.rb |
jheth
force-pushed
the
opportunity-record
branch
from
3932720 to
5a3aa37
Compare
jheth
force-pushed
the
opportunity-record
branch
from
5a3aa37 to
518264d
Compare
|
Thanks @iloveitaly. Just added to basic_record_spec. Should I add an opportunity_spec.rb as well? |
I've been bearish on individual specs for records. I'm fine with just a If there is no unique record functionality, they add a lot of maintinance weight with very little value. What do you think? Thanks for the PR! |
|
Merged with 371baf9 |
2 participants
No description provided.