fix: worker compilation should not be async #54
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rosen-vladimirov
force-pushed
the
vladimirov/sync-worker-pitch
branch
from
bfbf50d to
8f2c842
Compare
DimitarTachev
approved these changes
Feb 20, 2020
rosen-vladimirov
force-pushed
the
vladimirov/sync-worker-pitch
branch
from
8f2c842 to
3a0b216
Compare
In some cases, when using the AOT of Angular applications, multiple worker compilations may happen at the same time. As they share the same Angular Compiler instance, the compilation itself may fail. To resolve this, ensure there's only one compilation of a worker in a specified moment - start the next one after the current one finishes.
rosen-vladimirov
force-pushed
the
vladimirov/sync-worker-pitch
branch
from
7515a5a to
4b07012
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In some cases, when using the AOT of Angular applications, multiple worker compilations may happen at the same time. As they share the same Angular Compiler instance, the compilation itself may fail.
To resolve this, ensure there's only one compilation of a worker in a specified moment - start the next one after the current one finishes.
Fixes issue NativeScript/nativescript-cli#5247