Fix tns debug ios --justlaunch
#2758
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When `--justlaunch` flag is passed, CLI automatically disposes the `ios-device-lib` after execution of the command. However this closes all opened device sockets and breaks the debug command. So whenever you try `tns debug ios --justlaunch [--chrome]`, the debug application (NativeScript Inspector) or Chrome DevTools is unable to connect to device socket and fails with error. Fix this by keeping the `ios-device-lib` alive whenever we try debug for ios. This way the debug application will be able to connect to the device. NOTE: `tns debug ios --justlaunch [--chrome]` cannot release the terminal as it has to keep the ios-device-lib alive.
rosen-vladimirov
requested review from
dtopuzov,
Mitko-Kerezov,
pkoleva and
TsvetanMilanov
TsvetanMilanov
approved these changes
May 2, 2017
Mitko-Kerezov
approved these changes
May 2, 2017
dtopuzov
approved these changes
May 2, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When
--justlaunchflag is passed, CLI automatically disposes theios-device-libafter execution of the command. However this closes all opened device sockets and breaks the debug command.So whenever you try
tns debug ios --justlaunch [--chrome], the debug application (NativeScript Inspector) or Chrome DevTools is unable to connect to device socket and fails with error.Fix this by keeping the
ios-device-libalive whenever we try debug for ios. This way the debug application will be able to connect to the device.NOTE:
tns debug ios --justlaunch [--chrome]cannot release the terminal as it has to keep the ios-device-lib alive.