[DO NOT MERGE] feat: add log type prefixes to the logs #1717
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WIP - untested yet, adjustments might be required.
|
@triniwiz could we maybe get that in an alpha so that we can test it ? |
|
Landed separately in 9a10e2b |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WIP - untested yet, adjustments might be required.
Add the log type prefix to the console logs printed to ADB. This brings the format in line with the iOS (v8) runtime and allows further post-processing by the CLI to print different types in different colors.
This is part of the effort to make reading device/emulator logs easier and friendlier: NativeScript/nativescript-cli#5680