-
-
Notifications
You must be signed in to change notification settings - Fork 8
Add tests for window reload assertions and update API contracts & fakes #25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Add tests for window reload assertions and update API contracts & fakes #25
Conversation
|
Hey @AdrianDev374 Thank you for your contribution! This is looking great 🙏🏻 I ran into a tiny problem, which is not limited to what's added in this PR, but also exist on the other assertion methods. If we call refresh without any arguments it will automatically detect the current window eg The assertion however expects it to be given input. So this fails: I can fix this by making the id argument null by default. But it might be good to think about what's expected here. If you call |
|
Hi @gwleuverink In my opinion, it would be nice if the ID is null, it checks if the current window has been reloaded, and if an ID is passed, it checks if that window has been reloaded. In my application, I work with multiple windows, and I think it might be more interesting to be able to see if a specific window has been reloaded. |
|
Hey @gwleuverink Maybe adding this and making the id of the assert nullable. |
|
Code style workflow is failing on outside branch. All is green when running locally. We can skip that status check @NativePHP/contributors |
|
Waiting on #50 There are some window related tests that fail in that PR. Better to merge that first |
🧩 Description
Added support for testing window reload actions in WindowManagerFake.
Before this change, the fake only handled open, close, show, and hide, so we couldn’t verify when a component called Window::reload().
🚀 What’s new