makes name of new branch in ###Branching consistent #33
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@rjmk thanks 👍 Which do you think is more clear? |
NataliaLKB
added a commit
that referenced
this pull request
May 5, 2015
makes name of new branch in ###Branching consistent
|
I'm not generally a fan of the 'my*' naming pattern, but I guess it is slightly clearer that it's a parameter rather than command/option than just 'new-branch'. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
The name of the branch we are guided to create is originally 'my-new-branch', but then changes to 'new-branch'. I have changed it to be 'new-branch' from the beginning.
Hope I did everything right! :).