Move callback wrappers to Python layer #544
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vzhurba01
added
enhancement
|
/ok to test |
This comment has been minimized.
This comment has been minimized.
kkraus14
reviewed
Apr 2, 2025
leofang
reviewed
Apr 3, 2025
| cdef cuAsyncCallbackData *cbData = NULL | ||
| cbData = <cuAsyncCallbackData *>malloc(sizeof(cbData[0])) | ||
| if cbData == NULL: | ||
| return CUresult.CUDA_ERROR_OUT_OF_MEMORY |
There was a problem hiding this comment.
Q: Should this be a 1-tuple?
Suggested change
| return CUresult.CUDA_ERROR_OUT_OF_MEMORY | |
| return (CUresult.CUDA_ERROR_OUT_OF_MEMORY,) |
There was a problem hiding this comment.
Good catch. Fixed.
There was a problem hiding this comment.
It would be good to have type annotations or something else as a way to prevent issues like this from sneaking in.
There was a problem hiding this comment.
It seems currently Cython cannot raise a compile-time error for either case, only a run-time error (which is not desired I think).
cpdef tuple f():
return 42
def g() -> tuple:
return 42Output:
>>> import test_tuple
>>> test_tuple.f()
Traceback (most recent call last):
File "<stdin>", line 1, in <module>
File "test_tuple.pyx", line 1, in test_tuple.f
cpdef tuple f():
File "test_tuple.pyx", line 3, in test_tuple.f
return 42
TypeError: Expected tuple, got int
>>> test_tuple.g()
Traceback (most recent call last):
File "<stdin>", line 1, in <module>
File "test_tuple.pyx", line 7, in test_tuple.g
return 42
TypeError: Expected tuple, got int
Correct. |
|
/ok to test |
Merged
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
close #531