Skip to content

Move callback wrappers to the Python layer #531

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
vzhurba01 opened this issue Mar 24, 2025 · 0 comments · Fixed by #544
Closed

Move callback wrappers to the Python layer #531

vzhurba01 opened this issue Mar 24, 2025 · 0 comments · Fixed by #544
Assignees
@vzhurba01
Labels
cuda.bindings Everything related to the cuda.bindings module enhancement Any code-related improvements P0 High priority - Must do!
Milestone
cuda-python 12.9....

Comments

@vzhurba01
Copy link
Collaborator

vzhurba01 commented Mar 24, 2025 •
edited
Loading

Sounds like a good idea to

  • move the lifetime-related changes to another PR
  • ensure both driver/runtime Python layers have the lifetime management for callbacks
  • ensure both driver/runtime Cython layers have no lifetime management for callbacks (as if the CUDA C APIs are called from Cython, which was the intent AFAIK)

Originally posted by @leofang in #517 (comment)
@github-actions github-actions bot added the triage Needs the team's attention label Mar 24, 2025
@vzhurba01 vzhurba01 mentioned this issue Mar 24, 2025
Merged
@vzhurba01 vzhurba01 self-assigned this Mar 24, 2025
@vzhurba01 vzhurba01 added enhancement Any code-related improvements P0 High priority - Must do! cuda.bindings Everything related to the cuda.bindings module labels Mar 24, 2025
@vzhurba01 vzhurba01 added this to the cuda-python next milestone Mar 24, 2025
@vzhurba01 vzhurba01 changed the title Ah! I see, I overlooked the streamAddCallbackCommon function when checking the cudart code yesterday, thanks Vlad! Move callback wrappers to the Python layer Mar 24, 2025
@leofang leofang removed the triage Needs the team's attention label Mar 24, 2025
@vzhurba01 vzhurba01 mentioned this issue Apr 1, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@vzhurba01 vzhurba01

Labels
cuda.bindings Everything related to the cuda.bindings module enhancement Any code-related improvements P0 High priority - Must do!
Projects
None yet
Milestone
cuda-python 12.9.0 & 11.8.7
Development

Successfully merging a pull request may close this issue.

Move callback wrappers to Python layer vzhurba01/cuda-python
2 participants
@leofang @vzhurba01