Skip to content

Increase tolerance in test_timing() to avoid flaky tests. #498

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 7, 2025
Merged

Increase tolerance in test_timing() to avoid flaky tests. #498

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion cuda_core/tests/test_event.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,12 @@ def test_timing(init_cuda, enable_timing):
if enable_timing:
elapsed_time_ms = e2 - e1
assert isinstance(elapsed_time_ms, float)
assert delay_seconds * 1000 <= elapsed_time_ms < delay_seconds * 1000 + 2 # tolerance 2 ms
# Using a generous tolerance, to avoid flaky tests:
# We only want to exercise the __sub__ method, this test is not meant
# to stress-test the CUDA driver or time.sleep().
delay_ms = delay_seconds * 1000
generous_tolerance = 20
assert delay_ms <= elapsed_time_ms < delay_ms + generous_tolerance
else:
with pytest.raises(RuntimeError) as e:
elapsed_time_ms = e2 - e1
Expand Down