Add the cuda.core.experimental.system singleton #256
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ksimpson-work
changed the title
leofang
added
P0
ksimpson-work
force-pushed
the
add_system
branch
from
4bf49e4 to
7d5c742
Compare
leofang
requested changes
Nov 30, 2024
Co-authored-by: Leo Fang <[email protected]>
Co-authored-by: Leo Fang <[email protected]>
ksimpson-work
changed the title
leofang
requested changes
Dec 7, 2024
There was a problem hiding this comment.
@ksimpson-work I "hacked" the docs in commit 1a3f1e6. It's not pretty but it does the job:
One improvement we need to make: We need to rewrite the docstrings as a one-liner, as opposed to a legal Sphinx docstring. It is because the autodata directive only expects simple one-liners:
https://www.sphinx-doc.org/en/master/usage/extensions/autodoc.html#automatically-document-attributes-or-data
This is also the reason that there are 3 warnings raised if you build this locally.
leofang
reviewed
Dec 7, 2024
cuda_core/docs/source/conf.py
Outdated
Comment on lines
103
to
106
| n_pops = len(lines) | ||
| lines.extend(lines_new) | ||
| for _ in range(n_pops): | ||
| lines.pop(0) |
There was a problem hiding this comment.
try this?
Suggested change
| n_pops = len(lines) | |
| lines.extend(lines_new) | |
| for _ in range(n_pops): | |
| lines.pop(0) | |
| lines.clear() | |
| lines.extend(lines_new) |
|
|
|
latest commit fixes the build warning and properly formats the Returns field. Thanks for the hack @leofang |
Co-authored-by: Leo Fang <[email protected]>
|
/ok to test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add the cuda.core.experiemental.system singleton which is an instance of System.
closes #149