feat: add from_* style constructor classmethods to StridedMemoryView and make constructor amenable to future from_*-style constructors #1224
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Auto-sync is disabled for ready for review pull requests in this repository. Workflows must be run manually. Contributors can view more details about this message here. |
Contributor
Author
|
/ok to test |
|
cpcloud
force-pushed
the
smv-info-constructor
branch
from
786140a to
f7eef8d
Compare
Contributor
Author
|
/ok to test |
…and make constructor amenable to future from_*-style constructors
cpcloud
force-pushed
the
smv-info-constructor
branch
from
f7eef8d to
2cd276a
Compare
Contributor
Author
|
/ok to test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds three methods to conform better to APIs familiar to Python users and to ease future work on
StridedMemoryViewadding support for constructing them from other objects besides CAI and dlpack objects.
Three methods are added:
from_dlpack(obj, stream_ptr)same functionality as beforefrom_cuda_array_interface(obj, stream_ptr)same functionality as beforefrom_any_interface(obj, stream_ptr)same behavior as the previous constructorThe constructor changes to a simple field initialization, in an effort to make
it easier to add a
from_buffer(naming TBD) method that allows constructionfrom an owned raw buffer (without shape and stride information), which may
require passing in additional information such as shape and stride to the
constructor.