Skip to content

build: enable free-threading compatibility #1103

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Oct 8, 2025
Merged

build: enable free-threading compatibility #1103

merged 3 commits into from
Oct 8, 2025

Conversation

@cpcloud
Copy link
Contributor

@cpcloud cpcloud commented Oct 8, 2025

Enable freethreading_compatibility for cuda-python extension modules

@copy-pr-bot
Copy link
Contributor

copy-pr-bot bot commented Oct 8, 2025

Auto-sync is disabled for ready for review pull requests in this repository. Workflows must be run manually.

Contributors can view more details about this message here.

@cpcloud
Copy link
Contributor Author

cpcloud commented Oct 8, 2025

/ok to test

@cpcloud cpcloud requested a review from leofang October 8, 2025 13:25
@github-actions
Copy link

github-actions bot commented Oct 8, 2025

Doc Preview CI

🚀 View preview at
https://nvidia.github.io/cuda-python/pr-preview/pr-1103/

https://nvidia.github.io/cuda-python/pr-preview/pr-1103/cuda-core/

https://nvidia.github.io/cuda-python/pr-preview/pr-1103/cuda-bindings/

https://nvidia.github.io/cuda-python/pr-preview/pr-1103/cuda-pathfinder/


Preview will be ready when the GitHub Pages deployment is complete.

@cpcloud cpcloud requested a review from kkraus14 October 8, 2025 14:43
leofang
leofang approved these changes Oct 8, 2025
View reviewed changes
@leofang leofang added bug Something isn't working P0 High priority - Must do! cuda.bindings Everything related to the cuda.bindings module cuda.core Everything related to the cuda.core module labels Oct 8, 2025
@leofang leofang added this to the cuda.core beta 7 milestone Oct 8, 2025
leofang
leofang requested changes Oct 8, 2025
View reviewed changes
Copy link
Member

@leofang leofang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like when we build Cython tests, we also have to pass the new flag, e.g.:
https://github.com/NVIDIA/cuda-python/actions/runs/18346151043/job/52261604753?pr=1103#step:26:340

@cpcloud
Copy link
Contributor Author

cpcloud commented Oct 8, 2025

Gah, what is going on with system dependency installation?

@cpcloud
Copy link
Contributor Author

cpcloud commented Oct 8, 2025

Also, I will do a follow up to turn on warnings as errors in pytest.

@leofang
Copy link
Member

leofang commented Oct 8, 2025

Gah, what is going on with system dependency installation?

no idea, asking in the runner channel internally

@cpcloud cpcloud requested a review from leofang October 8, 2025 15:29
leofang
leofang reviewed Oct 8, 2025
View reviewed changes
Copy link
Member

@leofang leofang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

there is also cuda_core/tests/cython/build_tests.sh

@cpcloud
Copy link
Contributor Author

cpcloud commented Oct 8, 2025

I also handled build_tests.bat. I think this is ready to go now.

@leofang
Copy link
Member

leofang commented Oct 8, 2025

Good catch!

@leofang
Copy link
Member

leofang commented Oct 8, 2025

/ok to test 47c13be

@leofang
Copy link
Member

leofang commented Oct 8, 2025

I'll check the CI log later and see if the warning is gone.

Also, I will do a follow up to turn on warnings as errors in pytest.

It might be a good idea. Though I am not sure how much work it is. For this particular case, it might be a good idea to also add a naive test like this
https://github.com/numpy/numpy/blob/128d684bdc8d756c63341baab0fd7e4df3fbc09c/tools/wheels/cibw_test_command.sh#L22-L25

@leofang
Copy link
Member

leofang commented Oct 8, 2025

btw @cpcloud we'll need to backport the cuda-bindings changes...

@leofang
Copy link
Member

leofang commented Oct 8, 2025

I'll check the CI log later and see if the warning is gone.

Looks like they are gone now. I will enable auto-merge.

@leofang leofang enabled auto-merge (squash) October 8, 2025 17:00
@leofang leofang merged commit bd42838 into NVIDIA:main Oct 8, 2025
137 of 139 checks passed
@cpcloud cpcloud deleted the cython-ft branch October 8, 2025 17:27
github-actions bot pushed a commit that referenced this pull request Nov 10, 2025
Clean up PR preview folders for 61 closed/merged PRs
6fc9084 
Removed preview folders for the following PRs:
- PR #1021
- PR #1034
- PR #1052
- PR #1059
- PR #1069
- PR #1086
- PR #1090
- PR #1096
- PR #1102
- PR #1103
- PR #1106
- PR #1107
- PR #1117
- PR #1133
- PR #1140
- PR #1166
- PR #1174
- PR #1185
- PR #1188
- PR #1191
... and 41 more
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kkraus14 kkraus14 kkraus14 approved these changes

@leofang leofang leofang approved these changes

Assignees

@cpcloud cpcloud

Labels

bug Something isn't working cuda.bindings Everything related to the cuda.bindings module cuda.core Everything related to the cuda.core module P0 High priority - Must do!

Projects

None yet

Milestone

cuda.core beta 7

Development

Successfully merging this pull request may close these issues.

3 participants

@cpcloud @leofang @kkraus14