Skip to content

Conversation

@Fridah-nv
Copy link
Contributor

Change in #546 breaks some conditions of saving models in hf training example, this PR fix the issue by reverting change in checkpoint saving logic and update the config separately.

Related pipeline failure: https://gitlab-master.nvidia.com/omniml/modelopt/-/jobs/233869405

What does this PR do?

Type of change: ?

Overview: ?

Usage

# Add a code snippet demonstrating how to use this

Testing

Before your PR is "Ready for review"

  • Make sure you read and follow Contributor guidelines and your commits are signed.
  • Is this change backward compatible?: Yes/No
  • Did you write any new necessary tests?: Yes/No
  • Did you add or update any necessary documentation?: Yes/No
  • Did you update Changelog?: Yes/No

Additional Information

@Fridah-nv Fridah-nv self-assigned this Nov 20, 2025
@Fridah-nv Fridah-nv requested a review from a team as a code owner November 20, 2025 00:59
@codecov
Copy link

codecov bot commented Nov 20, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 74.43%. Comparing base (bc52b6c) to head (7e2a78e).
⚠️ Report is 5 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #580      +/-   ##
==========================================
- Coverage   74.44%   74.43%   -0.02%     
==========================================
  Files         182      182              
  Lines       18234    18234              
==========================================
- Hits        13575    13572       -3     
- Misses       4659     4662       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@Fridah-nv Fridah-nv merged commit 38550b0 into main Nov 21, 2025
27 checks passed
@Fridah-nv Fridah-nv deleted the fridah/fix-hf-save branch November 21, 2025 00:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants