FIX: fix for vailation time us->ns #266
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Author
|
It's just fixing erroneous code comments, but these erroneous comments can be very confusing. The official documentation uses the correct unit: nanoseconds (ns). |
glowkey
approved these changes
Dec 1, 2025
Collaborator
|
FYI: this repo requires all PRs to have a verified signature. |
Author
signature done, PTAL @glowkey |
calmkart
force-pushed
the
master
branch
2 times, most recently
from
97c90f3 to
8ef0c5e
Compare
Signed-off-by: Calm Peng <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
FIX: fix for vailation time us->ns
in dcgmlib/dcgm_fields.h define the VIOLATION are ns
but in testing/python3/dcgm_filed.py the VIOLATION filed comment all change to us.
This will also cause errors in the configuration comments in dcgm-exporter. I have checked the official documentation and tested the actual values, confirming that these values should all be in nanoseconds (ns).