-
Notifications
You must be signed in to change notification settings - Fork 28
Refactor of source retrieval provenance model #388
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Adding RetrievalSource object (and a reference to it form Edge) to support richer representations of retrieval provenance per NCATSTranslator#369.
edeutsch
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good
| an Edge. Note that a given Edge should have one and only one 'primary' | ||
| source, and may have any number of 'aggregator' or 'supporting data' | ||
| sources. | ||
| enum: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should these have biolink: prefixes?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
edeutsch
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
however, the build is failing because you have exceeded the dreaded 79 character limit.
|
super-fussy yamllint is still unhappy with this PR: |
TranslatorReasonerAPI.yaml
Outdated
| - primary knowledge source | ||
| - aggregator knowledge source | ||
| - supporting data source | ||
| previous_resource: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
maybe "upstream_resources" would be better?
- upstream seems better than "previous"?
- plural since an array?
remove trailing whitespaces, Edge.sources array minItems: 1, previous_resource -> upstream_resources, snake case enum values
|
Automatic checks are still failing. I think the problem is that on line 1124 there is an unclosed quote |
|
The automatic build is still failing. The goal would be to ensure that the automatic validation passes. |
|
Replaced with PR #393 (in which @sierra-moxon fixed syntax errors that were causing test failures, and made resourceRole an object to reference so that it can leverage biolink enums) |
Adding RetrievalSource object (and a reference to it form Edge) to support richer representations of retrieval provenance per #369.