Metarules implementation of road roundabouts #510
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
memo33
reviewed
Mar 16, 2025
Collaborator
memo33
left a comment
memo33
left a comment
There was a problem hiding this comment.
All in all, this looks good to me. The code is very clear and easy to follow, giving us confidence that it works as intended. (I haven't tested it in the game, but as long as all tile IDs defined on this branch can be constructed in the game, it should be fine.)
Member
Author
Thank you for your review. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request replaces the manually written RUL2 of the road roundabouts with a metarules implementation. It was motivated by coming changes to the street network, draggable diagonal streets were not compatible with the existing roundabout implementation.
The metarules code achieves a 90% reduction in RUL2 code by eliminating all adjacencies by way of a surrogate tile. The surrogate tile cannot be drawn in the game, but rather is used to trigger automatic adjacencies with the NAM.dll. Every roundabout tile overrides ortho avenue into the surrogate, and non-INRUL tiles are also overridden by the surrogate tile. In doing so, each roundabout tile is able to reliably override any other roundabout tile.