Skip to content

[FIX] 기록 생성 시 이미지 Optional 불가 문제 해결 #87

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
EunbeenDev merged 2 commits into from
Jan 31, 2025
Merged

[FIX] 기록 생성 시 이미지 Optional 불가 문제 해결 #87

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d003609
[FIX] 기록 생성 시 이미지 null 허용
EunbeenDev Jan 31, 2025
9e7c517
Merge pull request #86 from Move-Log/fix/record-image-nullable
EunbeenDev Jan 31, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 8 additions & 2 deletions src/main/java/com/movelog/domain/record/application/RecordService.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,8 +47,14 @@ public void createRecord(UserPrincipal userPrincipal, CreateRecordReq createReco
// User user = userRepository.findById(5L).orElseThrow(UserNotFoundException::new);
validateCreateRecordReq(createRecordReq);

String recordImgUrl = s3Util.uploadToRecordFolder(img);
log.info("recordImgUrl: {}", recordImgUrl);
String recordImgUrl;
if(img != null){
recordImgUrl = s3Util.uploadToRecordFolder(img);
log.info("recordImgUrl: {}", recordImgUrl);
}
else{
recordImgUrl = null;
}

String verb = createRecordReq.getVerbType();
try {
Expand Down
7 changes: 7 additions & 0 deletions src/main/java/com/movelog/domain/record/presentation/RecordController.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,7 @@
import io.swagger.v3.oas.annotations.responses.ApiResponse;
import io.swagger.v3.oas.annotations.responses.ApiResponses;
import lombok.RequiredArgsConstructor;
import lombok.extern.slf4j.Slf4j;
import org.springframework.data.domain.Page;
import org.springframework.http.ResponseEntity;
import org.springframework.security.core.annotation.AuthenticationPrincipal;
Expand All @@ -25,6 +26,7 @@
@RestController
@RequestMapping("api/v1/record")
@RequiredArgsConstructor
@Slf4j
public class RecordController {
private final RecordService recordService;
@Operation(summary = "기록 추가 API", description = "기록을 추가하는 API입니다.")
Expand All @@ -42,6 +44,11 @@ public ResponseEntity<?> createRecord(
@Parameter(description = "Schemas의 CreateRecordReq를 참고해주세요.", required = true) @RequestPart CreateRecordReq createRecordReq,
@RequestPart(value = "img", required = false) MultipartFile img
) {
// 이미지 null 체크
log.info("img: {}", img.isEmpty());
if(img.isEmpty()) {
img = null;
}
recordService.createRecord(userPrincipal, createRecordReq, img);
return ResponseEntity.ok(ApiResponseUtil.success(Message.builder().message("기록이 생성되었습니다.").build()));
}
Expand Down