Added hashed index, a bit more of geo-indexes, possibility to give _cls #994
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 similar comment
MRigal
force-pushed
the
fix/cls-index-at-desired-position
branch
from
d830638 to
f35d0b2
Compare
|
The tests should pass, @seglberg @thedrow @DavidBord I'd be happy about a review (and eventually a merge) |
|
OK, since nobody is reacting on it, I'll merge it also |
MRigal
added a commit
that referenced
this pull request
Jun 11, 2015
Added hashed index, a bit more of geo-indexes, possibility to give _cls
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is also not a "full strike" PR.
It will first need #946 to be merged, since it needs some Warning raising that are inside it.I would like to add more serious warnings for the dropDups version, as some people may be surprised it is not supported anymore by MongoDB.
It also implements the remaining indexes types used with the shortcut +/-/$, by adding # for hashed, ( for geo2dsphere indexes and ) for geohaystack. [I've tried to use earth curve representation by the parenthesis for these geo-indexes, they were no other obvious symbols IMHO...]
Also, it allows to specify where one wants to have the "cls" index, by allowing something like ("field1", "cls", "field2"). We were forcing "cls" to be the first part of a compound key and this can be bad, for example when one has a compound shard key, but wants some compound indexes using only the first part of the shard key