Php72 libsodium

[duckchip]

Since Magento2.3.2 came out, installations were not possible anymore because of the new libsodium dependency.

I added libsodium to the php72-fpm Dockerfile so that we could run it again.

I got my inspiration here

[danielozano]

Hi @duckchip! Have you tried the latest build of the images? As far as I remember I already added libsodium to php7.2 image!

You can check it here: 1ec33d9#diff-974a0fe05907a90d4c1216b78217d4a2R35

But if you've already tested it, and it's not working I will review it again!

[danielozano]

Here you've the actual content of the php 7.2 image (with libsodium): https://github.com/ModestCoders/dockerfiles/blob/master/php/7.2-fpm/Dockerfile#L37

[ihor-sviziev]

@danielozano,
I'm not sure if it was fixed or not, but in Magento 2.3.2 is needed sodium 1.0.18 or above, and when it was released in official php images this version was lover (not sure about current state), so that's why it should be removed and installed again.

Even in magento cloud docker images we have it:
https://github.com/magento/magento-cloud-docker/blob/c4389d1daa5aa3b63fcf359282f3c7caa718419a/images/php/7.2-fpm/Dockerfile#L102-L113

Validation in magento itself was improved in 2.3.3 (magento/magento2#23866), but people might still use 2.3.2 or 2.3.2-p2 where this fix is still missing.

[danielozano]

Hi @ihor-sviziev @duckchip I'll give a push to all the contributions this weekend (I'm sorry for the inactivity but it's due to lack of time)

Actually I think it's 1.0.17

php -i | grep -i libsodium
libsodium headers version => 1.0.17
libsodium library version => 1.0.17

Anyhow it could be dangerous if we always aim for the latest version. Do you agree?
RUN wget https://download.libsodium.org/libsodium/releases/LATEST.tar.gz

Maybe we should follow the same approach than the Magento cloud images and just aim for 1.0.18
curl -sL https://github.com/jedisct1/libsodium/archive/1.0.18-RELEASE.tar.gz

What do you think?

[ihor-sviziev]

Maybe we should follow the same approach than the Magento cloud images and just aim for 1.0.18
curl -sL https://github.com/jedisct1/libsodium/archive/1.0.18-RELEASE.tar.gz

What do you think?

I think it's good idea

[danielozano]

Hi! @duckchip I've updated the libsodium for php 7.2 images, and also added it to the php 7.1. You can check it on this PR: #14

You have it available for the tags:

• modestcoders/php:7.2-fpm
• modestcoders/php:7.2-fpm-4
• modestcoders/php:7.1-fpm
• modestcoders/php:7.1-fpm-4

Let me know if you need anything else. Thank you for your work!

[ihor-sviziev]

Looks good! Thank you!

[duckchip]

I will close this PR since it's fixed in #14
Thx @danielozano !