Skip to content

[setup] use torch.version.hip for rocm version check #1360

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Mar 1, 2025
Merged

[setup] use torch.version.hip for rocm version check #1360

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
22578e7
get rocm version from torch if not set
CSY-ModelCloud Mar 1, 2025
a9fb0ed
check torch.version.hip exists
CSY-ModelCloud Mar 1, 2025
872b138
add raw output comment
CSY-ModelCloud Mar 1, 2025
597f095
remove unused codes
CSY-ModelCloud Mar 1, 2025
4152cb2
remove unneeded import
CSY-ModelCloud Mar 1, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 6 additions & 4 deletions setup.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,8 @@

from setuptools import find_packages, setup

import torch

try:
from setuptools.command.bdist_wheel import bdist_wheel as _bdist_wheel
except BaseException:
Expand All @@ -38,6 +40,10 @@
ROCM_VERSION = os.environ.get('ROCM_VERSION', None)
SKIP_ROCM_VERSION_CHECK = os.environ.get('SKIP_ROCM_VERSION_CHECK', None)

if ROCM_VERSION is None and torch.version.hip:
ROCM_VERSION = ".".join(torch.version.hip.split(".")[:2]) # print(torch.version.hip) -> 6.3.42131-fa1d09cbd
os.environ["ROCM_VERSION"] = ROCM_VERSION

if ROCM_VERSION is not None and float(ROCM_VERSION) < 6.2 and not SKIP_ROCM_VERSION_CHECK:
sys.exit(
"GPTQModel's compatibility with ROCM versions below 6.2 has not been verified. If you wish to proceed, please set the SKIP_ROCM_VERSION_CHECK environment."
Expand Down Expand Up @@ -101,8 +107,6 @@ def get_version_tag() -> str:
if not BUILD_CUDA_EXT:
return "cpu"

import torch

if ROCM_VERSION:
return f"rocm{ROCM_VERSION}"

Expand All @@ -124,9 +128,7 @@ def get_version_tag() -> str:
if not os.getenv("CI"):
with open('requirements.txt') as f:
requirements = [line.strip() for line in f if line.strip()]
#subprocess.check_call([sys.executable, "-m", "pip", "install", "-r", "requirements.txt"])

import torch # noqa: E402

if TORCH_CUDA_ARCH_LIST is None:
HAS_CUDA_V8 = any(torch.cuda.get_device_capability(i)[0] >= 8 for i in range(torch.cuda.device_count()))
Expand Down