Skip to content

Fix generation_config.json not auto-saved #1292

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Feb 18, 2025
Merged

Fix generation_config.json not auto-saved #1292

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
e47c627
Fix `generation_config.json` not auto-saved
Qubitium Feb 18, 2025
47dad0b
Update writer.py
Qubitium Feb 18, 2025
10da3e5
update transformers 4.49.0
Qubitium Feb 18, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion gptqmodel/models/writer.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@
from huggingface_hub import split_torch_state_dict_into_shards
from huggingface_hub.constants import SAFETENSORS_WEIGHTS_FILE_PATTERN
from safetensors.torch import save_file as safe_save
from transformers import AutoConfig, PreTrainedTokenizerFast
from transformers import AutoConfig, PreTrainedTokenizerFast, GenerationConfig
from transformers.modeling_utils import no_init_weights
from transformers.models.auto.tokenization_auto import get_tokenizer_config
from transformers.utils.generic import ContextManagers
Expand Down Expand Up @@ -309,6 +309,10 @@ def save_quantized(

quantize_config.save_pretrained(save_dir)

# check for generation_config(.json)
if hasattr(self, "generation_config") and isinstance(self.generation_config, GenerationConfig):
self.generation_config.save_pretrained(save_dir)

# need to copy .py files for model/tokenizers not yet merged to HF transformers
if self.trust_remote_code:
copy_py_files(save_dir, model_id_or_path=self.model_local_path)
Expand Down
2 changes: 1 addition & 1 deletion requirements.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ datasets>=3.2.0
numpy>=2.2.2
torch>=2.2.0
safetensors>=0.5.2
transformers>=4.48.3
transformers>=4.49.0
threadpoolctl>=3.5.0
packaging>=24.2
device-smi==0.3.3
Expand Down