Add Serde Support #118
Merged
Add Serde Support #118
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
daxpedda
force-pushed
the
serde
branch
4 times, most recently
from
1f5b0cc to
c7b81d2
Compare
- Instead, if the crate feature is not enabled, we say that in the error message instead. - Implement `Serialize` skeleton. - Hook up `serde` in the CI. - Handle `#[serde(...)]` attributes without `De/Serialize`. - Add tests for all these new errors. - Add test to check for `#[derive(De/Serialize)`]` support without `#[derive_where(De/Serialize)]`.
|
The implementation is done, barring any bugs that still come up during testing. |
|
This is good to go! |
ModProg
approved these changes
May 17, 2025
|
This is great! Could you make a release with this change? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds
serde::De/Serializesupport.I've got the idea from serde-rs/serde#1900. The idea is to basically emit the whole item in the attribute macro again, let
serde_derivedo its thing and then remove it with another attribute macro that just voids the duplicate item again.Resolves #100.