Skip to content

Conversation

@Olawumi-11
Copy link

This is the branch I created for my MDF task. In this branch, I created a repository called Outreachy_Modeci_Projects where I created a separate folder for each of my task. In each folder is a Readme.md file that described the outline of each of this task. I humbly await your feedback on all this tasks. Thanks

@pgleeson
Copy link
Member

Thanks for this @TaofeeqatDev.

  • For the pytorch to mdf example, please make sure you have run it with the latetst version of mdf, which gives colors to the generated graph of the mdf model. Aslo, use the new solid_color=True option in mdf_model.to_graph_image
  • Can you run the model multiple times with different input digits to assess the % accuracy of the MDF model?
  • The keras_mdf.py file looks like it comes from a previous commit, which is not in our main branch. Can you be clear where this came from?
  • Can you add a new layer to your keras model and retrain it, and demonstrate that the newly generated mdf model also has the new structure? Note you should use these helper methods: https://github.com/ModECI/MDF/blob/main/examples/TensorFlow/Keras/keras2mdf.py

@Olawumi-11
Copy link
Author

Olawumi-11 commented Mar 25, 2023

@pgleeson As regards the last feedback on my project, I have added a new layer to my keras model as instructed and have also retrained it and generated the graph. I'm currently working on the helper functions you referred to in order to convert it to MDF.

Fix some grammatical errors in the  code
Paraphrased some sentences for better understanding
Create a new repository for MDF/outreachy projects.
Creating folder for the preliminary task of the MDF project
Created folder for the first task of my MDF project
Created a folder for my Second MDF task
Created folder for python version and pip freeze output of my virtual environments
Edited the readme file
Added the pip freeze and python -V output to the file.
1. Fix grammatical issues in the file
2. Paraphrase some sentences for better understanding
paraphrase some sentences for better comprehension
Created a folder for the conversion of keras to MDF
Created a folder for the conversion of pytorch to mdf
Describe the outline of the preliminary Task
uploaded the new keras model with 4 layers
I also implement the keras in MDF using the helper functions as instructed.
@pgleeson
Copy link
Member

Thanks @TaofeeqatDev.

  • It seems though some of your notebooks have disappeared in this version, particularly where the pytorch and keras generated models are converted to mdf.
  • Can you remove the files used to generate the images with graphviz from this commit (e.g. AB, example - text files which begin with digraph)?
  • Can you tell me where this file came from originally?

@Olawumi-11
Copy link
Author

Olawumi-11 commented Mar 27, 2023

Thanks @pgleeson

  • I removed the 2 notebooks in order to work on the changes you talked about base on your last feedback.
  • I will remove the files from the folder
  • I just confirmed the source of the script, it's from an ex-intern repository. I came across it while reviewing previous work that had been done. Since you already referred me to a new script, I'm currently working with that. Thanks

@Olawumi-11
Copy link
Author

Olawumi-11 commented Mar 28, 2023

@pgleeson as regards your comment on too many files in PR. My question is, do you want to upload just the two notebook, I mean the notebook for building the model and the one for converting to MDF. Just want to confirm this before I reupload my projects.
Do we also need to include the link to our pull request when recording our contribution on outreachy website or just the link to the project folders is enough?

This notebook demonstrate the conversion of pytorch to mdf using inception_v3 pretrained model
Notebook demonstrating the conversion of keras to MDF
Notebook demonstrating the conversion of keras to MDF
Notebook that demonstrate the conversion of keras to MDF
@Olawumi-11
Copy link
Author

Olawumi-11 commented Mar 28, 2023

@pgleeson as regards the last feedback on my task.

  • I have added a new layer to my keras model and retrained it.
  • I also use the helper functions you referred to for my keras to MDF conversion.
  • I'm currently working on the pytorch to MDF conversion and I will reupload it soon.

While working on the pytorch to MDF conversion I supply different input data to test the accuracy of my model. Sometimes the keras model output will be exactly the same as MDF, and sometimes there is usually a slight difference between their output.

@pgleeson
Copy link
Member

@TaofeeqatDev there shouldn't be any reason to remove files and reupload them, e.g. your notebooks. You should be managing files by adding/committing changes using git, rather adding/deleting them on the website.
Please do add the pytorch->mdf version and update that by committing changes to the same file.
Re the keras example, it seems to be just a toy example with dummy data in/out, correct? It would be better if it was a "real world" example, e.g. like the pytorch one
The file referred to in your keras notebook (from Keras_MDF import *) does not exist.

@Olawumi-11
Copy link
Author

@TaofeeqatDev there shouldn't be any reason to remove files and reupload them, e.g. your notebooks. You should be managing files by adding/committing changes using git, rather adding/deleting them on the website. Please do add the pytorch->mdf version and update that by committing changes to the same file. Re the keras example, it seems to be just a toy example with dummy data in/out, correct? It would be better if it was a "real world" example, e.g. like the pytorch one The file referred to in your keras notebook (from Keras_MDF import *) does not exist.

Thanks for the feedback... I will use the MNIST dataset that I use for my pytorch example

@Olawumi-11 Olawumi-11 closed this Mar 31, 2023
@Olawumi-11
Copy link
Author

I have opened a new pull request for my project. Thanks

@Olawumi-11 Olawumi-11 deleted the mdf_b branch April 1, 2023 09:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants