Skip to content

Explicitly set compression ratio on resulting jar files #78

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Trial97 wants to merge 1 commit into from
Closed

Explicitly set compression ratio on resulting jar files #78

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions src/main/java/net/minecraftforge/installer/actions/OfflineAction.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -78,6 +78,9 @@ public boolean run(File target, File installer) throws ActionCanceledException {

checkCancel();
try (ZipOutputStream zout = new ZipOutputStream(new FileOutputStream(target))) {
// Explicitly set compression level because of potential differences based on environment.
// See https://github.com/MinecraftForge/JarSplitter/pull/2
zout.setLevel(6);
Set<String> seen = new HashSet<>();

// Copy our input installer jar
Expand Down