Update dependencies and make tests work #71
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes gradle cache Rework test framework to actually test things
PaintNinja
reviewed
Jan 14, 2025
Contributor
PaintNinja
left a comment
PaintNinja
left a comment
There was a problem hiding this comment.
Done some review on my phone and left some notes to revisit later. Overall looks good!
coremods-test/src/test/java/net/minecraftforge/coremod/test/JSFileLoader.java
Outdated
Show resolved
Hide resolved
coremods-test-jar/src/main/java/net/minecraftforge/coremod/testjar/Counter.java
Outdated
Show resolved
Hide resolved
coremods-test/src/test/java/net/minecraftforge/coremod/test/TestLaunchTransformerBase.java
Outdated
Show resolved
Hide resolved
| import java.util.List; | ||
| import java.util.Set; | ||
|
|
||
| public class TestTransformerService implements ITransformationService { |
Contributor
There was a problem hiding this comment.
We should look into bundling this with ModLauncher
Member
Author
There was a problem hiding this comment.
We should but I don't want it exposed at runtime as it's fairly powerful api. So probably a test harness sub project
|
|
||
| changelog { | ||
| fromTag "1.0.0" | ||
| from '1.0.0' |
Contributor
There was a problem hiding this comment.
Todo: investigate a bouncer method in GradleUtils to undo this breaking change
coremods-test/src/test/java/net/minecraftforge/coremod/test/TestLaunchTransformerBase.java
Show resolved
Hide resolved
coremods-test/src/test/java/net/minecraftforge/coremod/test/TestLaunchTransformerBase.java
Outdated
Show resolved
Hide resolved
Member
|
Paint suggested a lot of code sanity changes, so I will wait for those to be applied before I start testing thoroughly. Everything looks good so far, and I actually have a framework to test raw ASM with, so thank you. |
PaintNinja
reviewed
Jan 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update GradleUtils which allows us to re-enable configuration cache.
Update Gradle wrapper, junit deps. and a few others
Rewrote the junit test project to actually load things into a transformed context and verify the coremods actually applied.