Add additional instruction searching to ASMAPI #59
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
This PR depends on #56 being merged in first. After it is merged, I will rebase this PR on top of it. For now, it includes those changes as well. |
LexManos
approved these changes
Nov 1, 2024
Jonathing
force-pushed
the
feat/jonathing/master/additional-insn-searching
branch
from
d28151b to
62391d5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When I added InsnType to ASMAPI, it allowed the ability of searching for a specific type of instruction. This is useful for finding labels after an index, for example with
ASMAPI.findFirstInstructionAfter(method, -1, ASMAPI.InsnType.LABEL, index). However, it might be desirable to search for the first instruction matching only the instruction type. This PR adds methods that account for that.