Skip to content

Conversation

MihaiCristianCondrea
Copy link
Owner

Summary

  • add an AdChoices view to the about screen native ad layout so the "Why this ad" icon can render
  • wire the ad loader to register the AdChoices view with the native ad view

Testing

  • ./gradlew test (fails: Android SDK is not available in the container environment)

https://chatgpt.com/codex/tasks/task_e_68cdcd01038c832dacc5f2ed5793bce1

Copy link

@chatgpt-codex-connector chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Codex Review: Here are some suggestions.

Reply with @codex fix comments to fix any unresolved comments.

About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you open a pull request for review, mark a draft as ready, or comment "@codex review". If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex fix this CI failure" or "@codex address that feedback".

Comment on lines 55 to 57
<com.google.android.material.textview.MaterialTextView
android:id="@+id/ad_headline"
android:layout_width="0dp"

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[P1] Reserve space for the AdChoices icon

The newly added AdChoicesView is anchored to the top-right of the constraint layout, but ad_headline still stretches all the way to parent (app:layout_constraintEnd_toEndOf="parent"). With no constraint or margin between these two views the headline text will occupy the same space as the AdChoices icon, so whichever view is drawn last will obscure the other. AdChoices must remain visible for policy compliance, so the headline should constrain to the start of @id/ad_choices (or similar) to avoid overlap.

Useful? React with 👍 / 👎.

@MihaiCristianCondrea MihaiCristianCondrea merged commit ab0dc7b into main Sep 19, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant