Skip to content

Conversation

@Nodonisko
Copy link
Contributor

Bump is necessary to fix type error in MetaMask/core#6054

@Nodonisko Nodonisko requested a review from a team July 2, 2025 15:20
@socket-security
Copy link

socket-security bot commented Jul 2, 2025

Review the following changes in direct dependencies. Learn more about Socket for GitHub.

Diff Package Supply Chain
Security
Vulnerability Quality Maintenance License
Added@​types/​lodash@​4.17.201001007893100
Updated@​metamask/​utils@​11.0.1 ⏵ 11.4.29910093 +196 +7100

View full report

Copy link
Contributor

@cryptodev-2s cryptodev-2s left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@cryptodev-2s cryptodev-2s changed the title chore: bump @metamask/utils package chore: bump @metamask/utils to ^11.4.2 Jul 2, 2025
@mcmire
Copy link
Contributor

mcmire commented Jul 2, 2025

@Nodonisko I'm curious, what is the type error?

@cryptodev-2s cryptodev-2s changed the title chore: bump @metamask/utils to ^11.4.2 chore: bump @metamask/utils to ^11.4.2 Jul 2, 2025
@cryptodev-2s cryptodev-2s merged commit 0e81436 into MetaMask:main Jul 2, 2025
22 checks passed
@Nodonisko
Copy link
Contributor Author

@mcmire Something like this in core package. It was caused by two different version of @metamask/utils, in the end dedupe solved it better, but I think it wouldn't hurt to update it here anyway.

Type 'JsonRpcError' is not assignable to type '{ data?: Json & ExactOptionalGuard; stack?: string; code: number; message: string; } | undefined'.
  Type 'JsonRpcError' is not assignable to type '{ data?: Json & ExactOptionalGuard; stack?: string; code: number; message: string; }' with 'exactOptionalPropertyTypes: true'. Consider adding 'undefined' to the types of the target's properties.
    Types of property 'data' are incompatible.
      Type 'import("/Users/danielsuchy/javascript/metamask-core/node_modules/@metamask/rpc-errors/node_modules/@metamask/utils/dist/json").Json & ExactOptionalGuard' is not assignable to type 'import("/Users/danielsuchy/javascript/metamask-core/node_modules/@metamask/utils/dist/json").Json & ExactOptionalGuard' with 'exactOptionalPropertyTypes: true'. Consider adding 'undefined' to the types of the target's properties.
        Type 'string & ExactOptionalGuard' is not assignable to type 'Json & ExactOptionalGuard' with 'exactOptionalPropertyTypes: true'. Consider adding 'undefined' to the types of the target's properties.
          Type 'string & ExactOptionalGuard' is not assignable to type 'string & ExactOptionalGuard'. Two different types with this name exist, but they are unrelated.
            Type 'string & ExactOptionalGuard' is not assignable to type 'ExactOptionalGuard' with 'exactOptionalPropertyTypes: true'. Consider adding 'undefined' to the types of the target's properties.
              Types of property '_exactOptionalGuard' are incompatible.
                Type 'typeof exactOptionalSymbol' is not assignable to type 'typeof exactOptionalSymbol'. Two different types with this name exist, but they are unrelated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants