Skip to content

Conversation

@legobeat
Copy link
Contributor

@legobeat legobeat commented May 9, 2023

This updates the shared stream API to be based on Node.js 10 instead of Node.js 8.

Upgrading to 4.x (bringing us to Node.js 18 stream api) will be saved for a later upgrade.

This is a breaking change.

@socket-security
Copy link

socket-security bot commented May 9, 2023

👍 Dependency issues cleared. Learn more about Socket for GitHub ↗︎

This PR previously contained dependency changes with security issues that have been resolved, removed, or ignored.

@legobeat legobeat force-pushed the deps-readable-stream branch from dfcf173 to 8726f39 Compare May 11, 2023 03:55
@legobeat legobeat force-pushed the deps-readable-stream branch from 8726f39 to 46d3558 Compare August 26, 2023 02:53
@socket-security
Copy link

Updated dependencies detected. Learn more about Socket for GitHub ↗︎

Packages Version New capabilities Transitives Size Publisher
readable-stream 2.3.3...3.6.2 None +0/-2 124 kB matteo.collina

@legobeat legobeat requested a review from rekmarks August 26, 2023 03:25
@legobeat legobeat marked this pull request as ready for review August 26, 2023 03:26
@legobeat legobeat added the dependencies Pull requests that update a dependency file label Aug 26, 2023
@legobeat legobeat requested a review from a team August 27, 2023 02:29
@legobeat legobeat force-pushed the deps-readable-stream branch 2 times, most recently from e283948 to 5f8e494 Compare August 27, 2023 23:36
@legobeat legobeat requested review from a team, Gudahtt, kumavis, naugtur and weizman August 27, 2023 23:37
@legobeat legobeat force-pushed the deps-readable-stream branch from 5f8e494 to c71df52 Compare August 28, 2023 01:10
weizman
weizman previously approved these changes Aug 28, 2023
Gudahtt
Gudahtt previously approved these changes Aug 29, 2023
Copy link
Member

@Gudahtt Gudahtt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@legobeat legobeat force-pushed the deps-readable-stream branch from c71df52 to 498df11 Compare August 29, 2023 18:16
@legobeat legobeat dismissed stale reviews from weizman and Gudahtt via b75a6a1 August 29, 2023 18:32
@legobeat
Copy link
Contributor Author

legobeat commented Sep 4, 2023

@legobeat legobeat mentioned this pull request Sep 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependencies Pull requests that update a dependency file

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants